v1.4.3 is broken on Windows

[XhmikosR]

While with v1.4.2 and the same settings/environment worked fine, with 1.4.3 I get the following

Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation.  All rights reserved.

C:\Users\xmr\Desktop\mpc-hc.org>ruby -v
ruby 1.9.3p484 (2013-11-22) [i386-mingw32]

C:\Users\xmr\Desktop\mpc-hc.org>jekyll build --trace
Configuration file: C:/Users/xmr/Desktop/mpc-hc.org/_config.yml
            Source: ./source/
       Destination: ./_site/
      Generating... C:/RailsInstaller/Ruby1.9.3/lib/ruby/1.9.1/fileutils.rb:247:
in `mkdir': Invalid argument - C:/Users/xmr/Desktop/mpc-hc.org/_site/C: (Errno::EINVAL)
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/1.9.1/fileutils.rb:247:in `fu_mkdir'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/1.9.1/fileutils.rb:221:in `block (2 levels) in mkdir_p'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/1.9.1/fileutils.rb:219:in `reverse_each'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/1.9.1/fileutils.rb:219:in `block in mkdir_p'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/1.9.1/fileutils.rb:205:in `each'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/1.9.1/fileutils.rb:205:in `mkdir_p'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/jekyll-1.4.3/lib/jekyll/convertible.rb:168:in `write'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/jekyll-1.4.3/lib/jekyll/site.rb:259:in `block in write'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/jekyll-1.4.3/lib/jekyll/site.rb:397:in `block (2 levels) in each_site_file'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/jekyll-1.4.3/lib/jekyll/site.rb:396:in `each'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/jekyll-1.4.3/lib/jekyll/site.rb:396:in `block in each_site_file'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/jekyll-1.4.3/lib/jekyll/site.rb:395:in `each'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/jekyll-1.4.3/lib/jekyll/site.rb:395:in `each_site_file'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/jekyll-1.4.3/lib/jekyll/site.rb:259:in `write'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/jekyll-1.4.3/lib/jekyll/site.rb:41:in `process'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/jekyll-1.4.3/lib/jekyll/command.rb:18:in `process_site'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/jekyll-1.4.3/lib/jekyll/commands/build.rb:23:in `build'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/jekyll-1.4.3/lib/jekyll/commands/build.rb:7:in `process'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/jekyll-1.4.3/bin/jekyll:77:in `block (2 levels) in <top (required)>'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/commander-4.1.5/lib/commander/command.rb:180:in `call'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/commander-4.1.5/lib/commander/command.rb:180:in `call'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/commander-4.1.5/lib/commander/command.rb:155:in `run'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/commander-4.1.5/lib/commander/runner.rb:402:in `run_active_command'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/commander-4.1.5/lib/commander/runner.rb:78:in `run!'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/commander-4.1.5/lib/commander/delegates.rb:11:in `run!'
        from C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/commander-4.1.5/lib/commander/import.rb:10:in `block in <top (required)>

My _config.yml https://github.com/mpc-hc/mpc-hc.org/blob/jekyll/_config.yml

[parkr]

Looks like this line uses / which is a Unix file path convention.

[parkr]

v1.4.3 is not necessary unless you're running a host, so I'd suggest downgrading to v1.4.2 for now and we'll fix this for v2.0.0 :)

[XhmikosR]

Yeah, I already did, but you know, gem install jekyll will get 1.4.3 :P

Thanks for looking into this, I hope a fix will be out soon. It's already hard to set things up on Windows, let's not make it harder for the poor Windows users :)

[mattr-]

We just need to make a small change. '/' -> File::SEPARATOR. I'll see if I can't take care of this later tonight.

[parkr]

@mattr- Is that enough, or do we have to set it to either / or C:\\?

[mattr-]

Dunno. I'll double check.

[perlauge]

As far as I can tell, then the issue is that the destination methods of page.rb and post.rb in the 1.4.3 gem are not the same as those on the master branch on GitHub.

As the implementations of the method seem alike I wonder why it hasn't been pulled up into convertible.rb

[Nukker]

Thank you the bug of solution . let me mark this bug

[tamouse]

You will have to adjust the following line as well, since that's checking if the last character is the path separator. Could do self.url[-1] == File::SEPARATOR instead...

[perlauge]

I politely disagree - URLs will use '/' as file separator. And in any case Ruby will convert Windows/DOS file separator '' to '/'
Try out:

C:\>irb
irb(main):001:0> File.expand_path('.')
=> "C:/"
irb(main):002:0>

C:\>

[perlauge]

As mentioned before, then the issue can be fixed (for Windows) by removing the destination methods of page.rband post.rb then add the following to convertible.rb

    def destination(dest)
      # The url needs to be unescaped in order to preserve the correct filename
      path = File.join(dest, CGI.unescape(self.url))
      path = File.join(path, "index.html") if path[/\.html$/].nil?
      path
    end

This is using the "append index.html" if the path doesn't end with a .html extension as seen in https://github.com/jekyll/jekyll/blob/master/lib/jekyll/post.rb#L261 and not as the page version https://github.com/jekyll/jekyll/blob/master/lib/jekyll/page.rb#L137 where the check is to see if the path ends with a /

I tested this by adding a permalink: ../../../../../../somefile line in the content matter - the result is project path/_site/somefile/index.html as wanted to be contained within the project.

[parkr]

@perlauge Can you please turn that into a PR? :)

[XhmikosR]

👍 for the PR :D