Only Require 'rouge' If It's Being Used #2057

Closed
parkr opened this Issue Feb 17, 2014 · 1 comment

Comments

Projects
None yet
3 participants
Owner

parkr commented Feb 17, 2014

Per #2055, it's clear that rouge needs to be installed to get Jekyll running. This won't fly. We can do 1 of 2 things:

  1. Add rouge as a runtime dependency
  2. Modify RedcarpetParser::WithRouge (somehow) to only require rouge after we know we're using it. I think this is the better solution, but we probably have to do some weird voodoo to get the include Rouge::Plugins::Redcarpet to be included properly.

@parkr parkr added the Bug label Feb 17, 2014

@mattr- mattr- assigned parkr and mattr- and unassigned mattr- and parkr Feb 28, 2014

parkr added a commit to jekyll/jekyll-sass-converter that referenced this issue Mar 4, 2014

sparanoid added a commit to sparanoid/sparanoid.com that referenced this issue Apr 1, 2014

@parkr parkr added this to the 2.0 milestone Apr 2, 2014

Owner

parkr commented Apr 3, 2014

Fixed by merge of #2189

@parkr parkr closed this Apr 3, 2014

@jekyllbot jekyllbot locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.