Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Only Require 'rouge' If It's Being Used #2057

Closed
parkr opened this Issue · 1 comment

2 participants

@parkr
Owner

Per #2055, it's clear that rouge needs to be installed to get Jekyll running. This won't fly. We can do 1 of 2 things:

  1. Add rouge as a runtime dependency
  2. Modify RedcarpetParser::WithRouge (somehow) to only require rouge after we know we're using it. I think this is the better solution, but we probably have to do some weird voodoo to get the include Rouge::Plugins::Redcarpet to be included properly.
@parkr parkr added the Bug label
@mattr- mattr- was assigned by parkr
@mattr- mattr- removed their assignment
@parkr parkr was assigned by mattr-
@parkr parkr was unassigned by mattr-
@mattr- mattr- self-assigned this
@parkr parkr referenced this issue from a commit in jekyll/jekyll-sass-converter
@parkr parkr Include rouge for now
See jekyll/jekyll#2057 for more info
38ea2f2
@sparanoid sparanoid referenced this issue from a commit in sparanoid/sparanoid.com
@sparanoid sparanoid chore: hot fix for `rouge` gem 0a72a80
@parkr parkr added this to the 2.0 milestone
@parkr
Owner

Fixed by merge of #2189

@parkr parkr closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.