New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when dealing with filenames that have more than one dot #208

Closed
lpenz opened this Issue Sep 5, 2010 · 2 comments

Comments

Projects
None yet
2 participants
@lpenz
Contributor

lpenz commented Sep 5, 2010

When a filename has more than one dot, its basename is built by excluding everything up to the first dot.

That behaviour generates the error bellow:
/var/lib/gems/1.8/gems/jekyll-0.7.0/bin/../lib/jekyll/page.rb:64:in gsub': can't convert nil into String (TypeError) from /var/lib/gems/1.8/gems/jekyll-0.7.0/bin/../lib/jekyll/page.rb:64:inurl'
from /usr/lib/ruby/1.8/rubygems/custom_require.rb:31:in inject' from /var/lib/gems/1.8/gems/jekyll-0.7.0/bin/../lib/jekyll/page.rb:63:ineach'
from /var/lib/gems/1.8/gems/jekyll-0.7.0/bin/../lib/jekyll/page.rb:63:in inject' from /var/lib/gems/1.8/gems/jekyll-0.7.0/bin/../lib/jekyll/page.rb:63:inurl'
from /var/lib/gems/1.8/gems/jekyll-0.7.0/bin/../lib/jekyll/page.rb:94:in to_liquid' from /var/lib/gems/1.8/gems/jekyll-0.7.0/bin/../lib/jekyll/page.rb:85:inrender'
from /var/lib/gems/1.8/gems/jekyll-0.7.0/bin/../lib/jekyll/site.rb:139:in render' from /var/lib/gems/1.8/gems/jekyll-0.7.0/bin/../lib/jekyll/site.rb:138:ineach'
from /var/lib/gems/1.8/gems/jekyll-0.7.0/bin/../lib/jekyll/site.rb:138:in render' from /var/lib/gems/1.8/gems/jekyll-0.7.0/bin/../lib/jekyll/site.rb:77:inprocess'
from /var/lib/gems/1.8/gems/jekyll-0.7.0/bin/jekyll:150
from /var/lib/gems/1.8/bin/jekyll:19:in `load'
from /var/lib/gems/1.8/bin/jekyll:19

@lpenz

This comment has been minimized.

Contributor

lpenz commented Sep 5, 2010

Pull request of issue #209 fixes this.

@lpenz

This comment has been minimized.

Contributor

lpenz commented Nov 17, 2010

Correctly generates file basename. Closed by b1049c8.

The previous procedure generated invalid basenames when the filename had
more than one dot.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.