Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spice up site_template feed #2438

Merged
merged 1 commit into from May 30, 2014
Merged

Spice up site_template feed #2438

merged 1 commit into from May 30, 2014

Conversation

pathawks
Copy link
Member

Added some features to the template feed that are used by jekyllrb.com

@@ -15,6 +18,12 @@ layout: none
<pubDate>{{ post.date | date: "%a, %d %b %Y %H:%M:%S %z" }}</pubDate>
<link>{{ post.url | prepend: site.baseurl | prepend: site.url }}</link>
<guid isPermaLink="true">{{ post.url | prepend: site.baseurl | prepend: site.url }}</guid>
{% for tag in post.tags %}
<category>{{ tag | xml_escape }}</category>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tags aren't categories, why include them here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, the reason it is included here is because that's how it is in the jekyllrb.com feed template. If it makes more sense to leave this out that'd be an easy fix, but is there a reason it is included there and not here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benbalter, have any thoughts here? I'm inclined to accept even if the semantics are kind of off.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to accept even if the semantics are kind of off.

If that's the only hold up, I can just leave out tags.
The only reason I did this is because that's the way jekyllrb.com is handling tags.

@parkr
Copy link
Member

parkr commented May 23, 2014

I'm totally up for this. @benbalter, any thoughts?

@benbalter
Copy link
Contributor

👍

parkr added a commit that referenced this pull request May 30, 2014
@parkr parkr merged commit 041f727 into jekyll:master May 30, 2014
parkr added a commit that referenced this pull request May 30, 2014
@pathawks pathawks deleted the spicy-feed branch May 31, 2014 02:57
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants