Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for hl_lines highlighting #2532

Merged
merged 4 commits into from Jun 25, 2014
Merged

Conversation

alexmedearis
Copy link
Contributor

This allows for key/value pairs of the form key="value1 value2 value3" to be passed as arguments to highlight.

In particular, hl_lines="3 4 5" etc. is valid highlight syntax, but previously did not parse correctly.

@parkr

@alexmedearis
Copy link
Contributor Author

In reference to #516

@parkr
Copy link
Member

parkr commented Jun 23, 2014

This LGTM. Can you please add an example in the docs, too? Thanks!

/cc @mattr- for his 👀

@parkr
Copy link
Member

parkr commented Jun 25, 2014

@mattr-'s verdict:

👍 :shipit:

@parkr
Copy link
Member

parkr commented Jun 25, 2014

Hrm, feeling weird about this. Can I have some other 👀 / 🧠s on this? @benbalter / @envygeeks?

@envygeeks
Copy link
Contributor

👍

parkr added a commit that referenced this pull request Jun 25, 2014
@parkr parkr merged commit cedbdf4 into jekyll:master Jun 25, 2014
parkr added a commit that referenced this pull request Jun 25, 2014
@NathanHazout
Copy link

I know this is old, but is there a way to make this work with the backtick syntax?

@NathanHazout
Copy link

Does this work on Jekyll 3.0 with rouge?

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants