New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filename with dot in front aren't synced anymore #363

Closed
oliparcol opened this Issue Jul 14, 2011 · 12 comments

Comments

Projects
None yet
10 participants
@oliparcol

oliparcol commented Jul 14, 2011

Filename with a dot in front (mainly important for .htaccess files) aren't synced anymore in jekyl 0.11.0.

Thanks,

@bzimmer

This comment has been minimized.

Show comment
Hide comment
@bzimmer

bzimmer Jul 15, 2011

I have the issue. I'm using:

$ ruby -v
ruby 1.8.7 (2009-06-12 patchlevel 174) [universal-darwin10.0]

When I rolled back to 0.10.0 all is working again.

thanks, brian

bzimmer commented Jul 15, 2011

I have the issue. I'm using:

$ ruby -v
ruby 1.8.7 (2009-06-12 patchlevel 174) [universal-darwin10.0]

When I rolled back to 0.10.0 all is working again.

thanks, brian

@belkadan

This comment has been minimized.

Show comment
Hide comment
@belkadan

belkadan Jul 15, 2011

I noticed this too; my personal branch has a fix at belkadan/jekyll@f5c5b42.

belkadan commented Jul 15, 2011

I noticed this too; my personal branch has a fix at belkadan/jekyll@f5c5b42.

@alanwsmith

This comment has been minimized.

Show comment
Hide comment
@alanwsmith

alanwsmith Jul 17, 2011

Same thing here.

My setup is as follows:


ruby 1.8.7 (2009-06-12 patchlevel 174) [universal-darwin10.0]
jekyll 0.11.0

From _config.yml
source: .
destination: ../html
plugins: ./_plugins


I have a .htaccess sitting in the source directory. When jekyll 0.11 builds the site, the .htaccess file is not moved. Additionally, if an .htaccess file was moved manually to the destination (e.g. ../html) directory, it gets removed when jekyll is run.

alanwsmith commented Jul 17, 2011

Same thing here.

My setup is as follows:


ruby 1.8.7 (2009-06-12 patchlevel 174) [universal-darwin10.0]
jekyll 0.11.0

From _config.yml
source: .
destination: ../html
plugins: ./_plugins


I have a .htaccess sitting in the source directory. When jekyll 0.11 builds the site, the .htaccess file is not moved. Additionally, if an .htaccess file was moved manually to the destination (e.g. ../html) directory, it gets removed when jekyll is run.

@alanwsmith

This comment has been minimized.

Show comment
Hide comment
@alanwsmith

alanwsmith Jul 17, 2011

Incidentally, jekyll is my first ruby experience. If someone wouldn't mind telling me an easy way to roll back to version 0.10 I would greatly appreciate it (as it would save me some googleing or stackoverflowing and let me get back to messing with jekyll itself).

Thanks,
-a

alanwsmith commented Jul 17, 2011

Incidentally, jekyll is my first ruby experience. If someone wouldn't mind telling me an easy way to roll back to version 0.10 I would greatly appreciate it (as it would save me some googleing or stackoverflowing and let me get back to messing with jekyll itself).

Thanks,
-a

@bzimmer

This comment has been minimized.

Show comment
Hide comment
@bzimmer

bzimmer Jul 17, 2011

You can try (I use a mac):

sudo gem uninstall -v 0.11.0 jekyll
sudo gem install -v 0.10.0 jekyll

bzimmer commented Jul 17, 2011

You can try (I use a mac):

sudo gem uninstall -v 0.11.0 jekyll
sudo gem install -v 0.10.0 jekyll

@alanwsmith

This comment has been minimized.

Show comment
Hide comment
@alanwsmith

alanwsmith Jul 17, 2011

Thank you, @bzimmer. That worked great.

Cheers,
-Alan

alanwsmith commented Jul 17, 2011

Thank you, @bzimmer. That worked great.

Cheers,
-Alan

@sumbach

This comment has been minimized.

Show comment
Hide comment
@sumbach

sumbach Jul 21, 2011

This looks like the culprit: 13cc44f#L2L213

Dir.entries includes dotfiles (e.g., .htaccess), Dir['*'] does not.

sumbach commented Jul 21, 2011

This looks like the culprit: 13cc44f#L2L213

Dir.entries includes dotfiles (e.g., .htaccess), Dir['*'] does not.

@jnrbsn

This comment has been minimized.

Show comment
Hide comment
@jnrbsn

jnrbsn Aug 8, 2011

@sumbach I apologize if this is a dumb question, but do you know if reverting line 213 of lib/jekyll/site.rb (the line to which you're referring in the commit to which you linked) would break anything else?

jnrbsn commented Aug 8, 2011

@sumbach I apologize if this is a dumb question, but do you know if reverting line 213 of lib/jekyll/site.rb (the line to which you're referring in the commit to which you linked) would break anything else?

@sumbach

This comment has been minimized.

Show comment
Hide comment
@sumbach

sumbach Aug 8, 2011

@jnrbsn Looking at the filter_entries code, I suspect that does not exclude any dotfiles if you revert line 213. I think you'd need to use File.basename(e) to get the desired exclusion of dotfiles and exclusions from your config file.

It would be awesome to put a test suite in place to characterize the current behavior and clarify what's wrong about it. If you don't get to it before then, I'll plan on building a test suite this Friday.

sumbach commented Aug 8, 2011

@jnrbsn Looking at the filter_entries code, I suspect that does not exclude any dotfiles if you revert line 213. I think you'd need to use File.basename(e) to get the desired exclusion of dotfiles and exclusions from your config file.

It would be awesome to put a test suite in place to characterize the current behavior and clarify what's wrong about it. If you don't get to it before then, I'll plan on building a test suite this Friday.

@Juev

This comment has been minimized.

Show comment
Hide comment
@Juev

Juev Aug 9, 2011

I went a little easier. Created the file htaccess, without a dot at the beginning of the file name with the following contents:

---
layout: none
permalink: .htaccess
---
Redirect 301 /linode http://www.linode.com

And now, the generation of the site is created the file.

Juev commented Aug 9, 2011

I went a little easier. Created the file htaccess, without a dot at the beginning of the file name with the following contents:

---
layout: none
permalink: .htaccess
---
Redirect 301 /linode http://www.linode.com

And now, the generation of the site is created the file.

@alanwsmith

This comment has been minimized.

Show comment
Hide comment
@alanwsmith

alanwsmith Aug 15, 2011

@Juev - That's a great idea. Even if when the issue is fixed I'm going to keep doing that just to make the file show up in the Mac Finder window without having to show all hidden files. Very nice.

alanwsmith commented Aug 15, 2011

@Juev - That's a great idea. Even if when the issue is fixed I'm going to keep doing that just to make the file show up in the Mac Finder window without having to show all hidden files. Very nice.

@brandonarbini

This comment has been minimized.

Show comment
Hide comment
@brandonarbini

brandonarbini Oct 27, 2011

@Juev - Bingo. So simple...should have thought of it myself. :) Thanks!

brandonarbini commented Oct 27, 2011

@Juev - Bingo. So simple...should have thought of it myself. :) Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.