Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WOFF2 font format #3647

Merged
merged 1 commit into from Apr 10, 2015
Merged

Add WOFF2 font format #3647

merged 1 commit into from Apr 10, 2015

Conversation

nhoizey
Copy link
Contributor

@nhoizey nhoizey commented Apr 9, 2015

No description provided.

@parkr
Copy link
Member

parkr commented Apr 9, 2015

@azizshamim Is this in the GHP mime types file? We're trying to maintain parity.

@envygeeks
Copy link
Contributor

I don't know how he would know that because he doesn't have access to their servers?

@alfredxing
Copy link
Member

I created a test repo, and it seems that WOFF files are served as application/x-font-woff (as expected), but WOFF2 files are still being served as application/octet-stream, which probably means GitHub hasn't added this on their end yet.

@parkr
Copy link
Member

parkr commented Apr 10, 2015

I don't know how he would know that because he doesn't have access to their servers?

@envygeeks Aziz works on GitHub's infrastructure. He knows. :)

@alfredxing Ok, then it's time for a support request! I'll send it now.

@parkr
Copy link
Member

parkr commented Apr 10, 2015

On hold at the moment. Got a response from GitHub, but the W3C spec doesn't specify this MIME Type (and is vague about which one to use).

@envygeeks
Copy link
Contributor

The spec states application/font-woff2 which will more than likely be what it will land as in the final spec.

@parkr
Copy link
Member

parkr commented Apr 10, 2015

@envygeeks Are you looking at http://dev.w3.org/webfonts/WOFF2/spec/#IMT ?

@envygeeks
Copy link
Contributor

parkr added a commit that referenced this pull request Apr 10, 2015
@parkr parkr merged commit 6d6c15e into jekyll:master Apr 10, 2015
parkr added a commit that referenced this pull request Apr 10, 2015
@parkr
Copy link
Member

parkr commented Apr 10, 2015

I'm convinced! Thanks. 😄

@parkr
Copy link
Member

parkr commented Apr 10, 2015

/cc @jdennes ❤️

@nhoizey
Copy link
Contributor Author

nhoizey commented Apr 10, 2015

\o/

Thanks!

@envygeeks
Copy link
Contributor

❤️

@jdennes
Copy link

jdennes commented Apr 12, 2015

We've deployed the corresponding change on the GitHub side. GitHub Pages will now serve .woff2 files with a Content-Type header value of application/font-woff2.

@parkr
Copy link
Member

parkr commented Apr 12, 2015

Thank you so much @jdennes!!!!!!!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants