New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A pretty permalink should end with a slash #39

Closed
eugenebolshakov opened this Issue May 10, 2009 · 2 comments

Comments

Projects
None yet
3 participants
@eugenebolshakov
Contributor

eugenebolshakov commented May 10, 2009

AFAIK when apache gets a request like /path/to/post it looks for a file named "post" by default, not a directrory. That's why a mod rewrite rule is often added that redirects such requests to /path/to/post/ (basically just adds a trailing slash) and everything works well.

However the links in jekyll still don't have that trailing slash which confuses disqus. Comments are added to a page with the trailing slash and counters are requested for a page without the slash.

I think the pretty permalinks template should have the trailing slash to avoid the redirect and make disqus comments counters work correctly. I have it my fork http://github.com/eugenebolshakov/jekyll/tree/trailing-slashes-for-pretty-permalinks

It's obviously a tiny fix. I've also added the entire test/dest directory to .gitignore

@qrush

This comment has been minimized.

Show comment
Hide comment
@qrush

qrush Jun 23, 2009

Contributor

Merged in. Thanks!

Contributor

qrush commented Jun 23, 2009

Merged in. Thanks!

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jan 11, 2015

With respect, pretty permalinks should not end with slashes. I understand why they have to in this case, and this comment isn't directed at a specific person, but the fact that Jekyll has to mangle proper URL form to appease a second-rate commenting service (Disqus is basically the Experts Exchange of comments) is a kludge, plain and simple, and it goes against everything Jekyll stands for IMO.

Jekyll's current handling of this leads to the creation of wasteful /foo/index.html structures and a small avalanche of "clean URLs" plugins to fix them and turns Jekyll and GH Pages into, essentially, a massive on-ramp into Disqus. Which doesn't have Markdown, doesn't have decent code formatting support, and is generally considered a PITA by users.

Devs who are interested in quality Jekyll websites should shun Disqus like the plague. It's easy enough to roll your own comment support over AJAX without violating basic precepts of URL composition or wasting server resources on pointless folder-stuffing.

ghost commented Jan 11, 2015

With respect, pretty permalinks should not end with slashes. I understand why they have to in this case, and this comment isn't directed at a specific person, but the fact that Jekyll has to mangle proper URL form to appease a second-rate commenting service (Disqus is basically the Experts Exchange of comments) is a kludge, plain and simple, and it goes against everything Jekyll stands for IMO.

Jekyll's current handling of this leads to the creation of wasteful /foo/index.html structures and a small avalanche of "clean URLs" plugins to fix them and turns Jekyll and GH Pages into, essentially, a massive on-ramp into Disqus. Which doesn't have Markdown, doesn't have decent code formatting support, and is generally considered a PITA by users.

Devs who are interested in quality Jekyll websites should shun Disqus like the plague. It's easy enough to roll your own comment support over AJAX without violating basic precepts of URL composition or wasting server resources on pointless folder-stuffing.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.