Plugins directory is not updated when source directory is set. #405

Closed
Zegnat opened this Issue Sep 24, 2011 · 3 comments

Comments

Projects
None yet
4 participants
@Zegnat

Zegnat commented Sep 24, 2011

The plugins documentation tells us you should add the _plugins directory in your site source root. I have set a seperate ‘source’ in my _config.yml so I assumed it had to go in there, just like _layouts. Apparently I was wrong.

Updating the value for ‘source’ does not automatically overwrite the default setting for ‘plugins’. I personally think this is a bug and should be fixed as all other data folders (_layouts, _includes) do respect the customised source folder.

Is there some idea behind this or did it just end up this way because the _config.yml and DEFAULTS merging does not support any edge cases?

@envygeeks

This comment has been minimized.

Show comment Hide comment
@envygeeks

envygeeks Oct 4, 2011

Contributor

This is because defaults puts it at File.join(Dir.pwd, "_plugins") (the dir you call Jekyll from) change plugins in config

Contributor

envygeeks commented Oct 4, 2011

This is because defaults puts it at File.join(Dir.pwd, "_plugins") (the dir you call Jekyll from) change plugins in config

@Zegnat

This comment has been minimized.

Show comment Hide comment
@Zegnat

Zegnat Oct 6, 2011

[envygeeks:] This is because defaults puts it at File.join(Dir.pwd, "_plugins")

I know that. My point still stands as it is:

[Zegnat:] I personally think this is a bug and should be fixed as all other data folders (_layouts, _includes) do respect the customised source folder.

Zegnat commented Oct 6, 2011

[envygeeks:] This is because defaults puts it at File.join(Dir.pwd, "_plugins")

I know that. My point still stands as it is:

[Zegnat:] I personally think this is a bug and should be fixed as all other data folders (_layouts, _includes) do respect the customised source folder.

@parkr

This comment has been minimized.

Show comment Hide comment
@parkr

parkr Mar 16, 2013

Member

Fixed in #654.

Member

parkr commented Mar 16, 2013

Fixed in #654.

@parkr parkr closed this Mar 16, 2013

@jekyllbot jekyllbot locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.