Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Cannot pass hl_lines to pygments #516

Closed
madhur opened this Issue · 9 comments

7 participants

@madhur

There is a bug in this file, which prevents hl_lines parameter from being used.
https://github.com/mojombo/jekyll/blob/master/lib/jekyll/tags/highlight.rb

The regex SYNTAX needs to be modified to allow values of form name="value1 value2 value3" because hl_lines expects a list, but not a single value.

@parkr parkr closed this
@parkr
Owner

We'll revisit this if enough people ask for it.

@parkr parkr reopened this
@parkr
Owner

I definitely don't like the code in that patch but if we can get this to be looser so we can do multi-line highlights, I'm all for it. I was clearly way too swamped four months ago. :)

@rahmatawaludin

Me too, I cannot pass line highlight. Thanks for great jekyll.. :smile:

@alexmedearis

I would like to use this feature as well.

@parkr
Owner

I'd love a PR if any of you have time. :smiley:

@nghuuphuoc

+1 for that feature

@parkr
Owner

Should now work.

@parkr parkr closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.