New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loading data from subdir with a period in name #5433
Fix loading data from subdir with a period in name #5433
Conversation
if File.directory?(path) | ||
read_data_to(path, data[key] = {}) | ||
read_data_to(path, data[entry] = {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might still need to do sanitize_filename
here to make this accessible in Liquid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, so "categories.01" will become "categories01", right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! I believe having .
's in the key is not acceptable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! 🎉
@jekyllbot: merge +bug |
Fix #5429
If we're processing a directory - use it's name as a key.