New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document difference between cgi_escape and uri_escape #5970

Closed
pathawks opened this Issue Mar 21, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@pathawks
Member

pathawks commented Mar 21, 2017

The only difference I can find is in how each encodes a space:

{{ "Hello World" | cgi_escape }} => "Hello+World"
{{ "Hello World" | uri_escape }} => "Hello%20World"

We should explain this in https://jekyllrb.com/docs/templates/

See also #5969 (comment)
/cc: @jekyll/documentation

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 21, 2017

Member

Yes, please!

Member

parkr commented Mar 21, 2017

Yes, please!

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Mar 21, 2017

Member
{{ "this & that" | cgi_escape }} => "this+%26+that"
{{ "this & that" | uri_escape }} => "this%20&%20that"
Member

pathawks commented Mar 21, 2017

{{ "this & that" | cgi_escape }} => "this+%26+that"
{{ "this & that" | uri_escape }} => "this%20&%20that"
@jekyllbot

This comment has been minimized.

Show comment
Hide comment
@jekyllbot

jekyllbot May 21, 2017

Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the 3.3-stable or master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider building it first as a plugin. Jekyll 3 introduced hooks which provide convenient access points throughout the Jekyll build pipeline whereby most needs can be fulfilled. If this is something that cannot be built as a plugin, then please provide more information about why in order to keep this issue open.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

Contributor

jekyllbot commented May 21, 2017

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the 3.3-stable or master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider building it first as a plugin. Jekyll 3 introduced hooks which provide convenient access points throughout the Jekyll build pipeline whereby most needs can be fulfilled. If this is something that cannot be built as a plugin, then please provide more information about why in order to keep this issue open.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@jekyllbot jekyllbot added the stale label May 21, 2017

crispgm added a commit to crispgm/jekyll that referenced this issue May 22, 2017

jekyllbot added a commit that referenced this issue Jun 14, 2017

@parkr parkr closed this Jun 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment