Kramdown test fails due to new version of kramdown gem #647

Closed
adhearn opened this Issue Sep 23, 2012 · 2 comments

Projects

None yet

2 participants

@adhearn
adhearn commented Sep 23, 2012

I was attempting to run 'rake test' and I received the following error:

test: kramdown should convert quotes to smart quotes. (TestKramdown) [/home/adhearn/jekyll/test/test_kramdown.rb:26]: <"<p>&ldquo;Pit&rsquo;hy&rdquo;</p>"> expected but was <"<p>&#8220;Pit&#8217;hy&#8221;</p>">.

After looking up HTML character encoding (http://en.wikipedia.org/wiki/List_of_XML_and_HTML_character_entity_references), &#8220 and &ldquo are the same, as are (&#8221 and &rdquo) and (&#8217 and &rsquo).

If I comment out the first assert_equal, the second assert fails for the same reason:

test: kramdown should convert quotes to smart quotes. (TestKramdown) [/home/adhearn/Programming/jekyll/test/test_kramdown.rb:30]: <"<p>&laquo;Pit&rsaquo;hy&raquo;</p>"> expected but was <"<p>&#171;Pit&#8250;hy&#187;</p>">.

My gem version for kramdown is 0.14.0. According to the kramdown website (http://kramdown.rubyforge.org/news.html), "Numeric instead of symbolic HTML entities are now the default fallback," so it sounds like a version incompatibility. I've made the obvious changes to the test code in my fork, but a change to documentation to require an older version of kramdown might cause fewer breakages for other people.

@parkr
Member
parkr commented Dec 8, 2012

v0.14.0 may have changed this. Try it with v0.13.4 (as required in the gemspec). Do the tests pass?

@adhearn
adhearn commented Dec 11, 2012

Yes, they pass with 13.4. I mostly meant this to be an advisory for others, since the online documentation doesn't explicitly specify a version (even though the gemspec does).

@adhearn adhearn closed this Dec 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment