Jekyll exits with a 0 status when Maruku reports errors #673

Closed
miketheman opened this Issue Nov 13, 2012 · 7 comments

Comments

Projects
None yet
4 participants

Try adding an unterminated/malformed http link, such as:

[(http://exmaple.com)

Execute:

jekyll --no-auto --no-server ; echo $?

Output will provide:

....
Unclosed span (waiting for ["]"] ornil)
....

which is a maruku_error, yet the exit code will be 0.

Owner

parkr commented Dec 8, 2012

This looks like a common theme. In bin/jekyll, all errors are followed by exit 0, so it's probably on purpose. @mojombo?

Owner

parkr commented Dec 19, 2012

We're probably going to get rid of support for Maruku (in favour of RedCarpet), but that won't be for a bit. Elevating to see what Tom has to say about this – looks like a design choice in the code.

If the desire is to exit cleanly all the time, I get that, it does make valid rendering harder.

Do you know if RedCarpet adheres to some sort of exit code logic?

Contributor

mojombo commented Dec 20, 2012

I'd love to have non-zero exit codes for all exits caused by errors. Not sure how bin/jekyll ended up this way (probably laziness on my part in the early days), but feel free to change things to have unix compliant behavior.

parkr closed this in f211560 Jun 7, 2013

Woohoo!!!

Owner

parkr commented Jun 7, 2013

Thanks for your patience!!

jekyllbot locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.