Remind user to resolve conflict in jekyll new with --force
#6801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Feb 25, 2018
lib/jekyll/commands/new.rb
Outdated
| Jekyll.logger.abort_with "Conflict:", | ||
| "#{new_blog_path} exists and is not empty." | ||
| Jekyll.logger.error "Conflict:", "#{new_blog_path} exists and is not empty." | ||
| Jekyll.logger.abort_with "", "Use '--force' to overwrite and create anyway." |
There was a problem hiding this comment.
I'm not sure about this wording. Can we make it a bit less forceful? Using --force shouldn't be recommended as the default option.
There was a problem hiding this comment.
bit less forceful?
haha..
Using
--forceshouldn't be recommended as the default option.
"Ensure the #{new_blog_path} is empty or else try again with `--force`
to proceed and overwrite any files"
DirtyF
approved these changes
Feb 25, 2018
Crunch09
approved these changes
Feb 27, 2018
|
@jekyllbot: merge +minor |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #6797 (comment) by @pathawks
/cc @chrisfinazzo