Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warning: Using the last argument as keyword parameters is deprecated (Ruby 2.7.0) #7947

Closed
DirtyF opened this issue Dec 25, 2019 · 9 comments · Fixed by #7948
Closed

warning: Using the last argument as keyword parameters is deprecated (Ruby 2.7.0) #7947

DirtyF opened this issue Dec 25, 2019 · 9 comments · Fixed by #7948
Labels
frozen-due-to-age internal

Comments

@DirtyF
Copy link
Member

DirtyF commented Dec 25, 2019

My Environment

Software Version(s)
Operating System macOS
jekyll Latest
ruby Latest

Expected Behaviour

No warnings output when generating jekyll website with Ruby 2.7.0

Current Behavior

bundle exec rake site:generate

/code/jekyll/lib/jekyll/convertible.rb:41: warning: Using the last argument as keyword parameters is deprecated
/code/jekyll/lib/jekyll/document.rb:466: warning: Using the last argument as keyword parameters is deprecated
/code/jekyll/lib/jekyll/document.rb:432: warning: Passing the keyword argument as the last hash parameter is deprecated
/code/jekyll/lib/jekyll/document.rb:75: warning: The called method `merge_data!' is defined here
/code/jekyll/lib/jekyll/document.rb:439: warning: Passing the keyword argument as the last hash parameter is deprecated
/code/jekyll/lib/jekyll/tags/include.rb:179: warning: Using the last argument as keyword parameters is deprecated

For more explanation on what is deprecated, see https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
@ashmaroli
Copy link
Member

ashmaroli commented Dec 25, 2019 •
edited

Ruby 2.7 seems to be using lesser memory than Ruby 2.6

--- Travis build on Ruby 2.6.3
+++ Travis build on Ruby 2.7.0

- Total allocated: 425.21 MB (3818102 objects)
- Total retained:  19.86 MB (105724 objects)
+ Total allocated: 378.97 MB (3783442 objects)
+ Total retained:  19.53 MB (103632 objects)

@DirtyF Is there any significant speed improvement?

@ashmaroli ashmaroli mentioned this issue Dec 25, 2019
Merged
@DirtyF
Copy link
Member Author

DirtyF commented Dec 25, 2019

@ashmaroli nothing really noticeable without a proper benchmark 🤷‍♂

Ruby 2.7 also introduced better memory defragmentation, but I'm not sure it's applicable to Jekyll:
https://bugs.ruby-lang.org/issues/15626

@eirannejad
Copy link

eirannejad commented Feb 18, 2020 •
edited

Is there any way to suppress these warnings? Currently using bundle exec jekyll serve 2>/dev/null

@DirtyF
Copy link
Member Author

DirtyF commented Feb 18, 2020

Is there any way to suppress these warnings? Currently using bundle exec jekyll serve 2>/dev/null

Use current master until the 4.1 release: #7948 (comment)

@jkillingsworth jkillingsworth mentioned this issue Feb 25, 2020
Closed
This was referenced Feb 26, 2020
Open
Open
Open
@phieri phieri mentioned this issue Mar 8, 2020
Closed
AndrewKvalheim added a commit to SeaGL/seagl.github.io that referenced this issue Mar 8, 2020
@AndrewKvalheim
Restrict Ruby version, update dependencies.
63c776a 
- Stay on Ruby 2.6 until resolution to jekyll/jekyll#7947 is available via
  github-pages.
drizzt added a commit to emergenzeHack/covid19italia_segnalazioni that referenced this issue Mar 18, 2020
@drizzt
Usa Ruby 2.6 (jekyll/jekyll#7947)
fae147d
drizzt added a commit to emergenzeHack/covid19italia_segnalazioni that referenced this issue Mar 18, 2020
@drizzt
Usa Ruby 2.6 (jekyll/jekyll#7947)
6046b81
@tcab tcab mentioned this issue Mar 24, 2020
Closed
@ajyong ajyong mentioned this issue Apr 12, 2020
Merged
zkamvar added a commit to carpentries/lesson-docker that referenced this issue May 19, 2020
@zkamvar
hide warnings from Jekyll
9bfe22e 
In the new Ruby, there's a warning from Jekyll about using the last
argument as keyword parameters. I've found that others are equally
frustrated by this and have resorted to either upgrading (not yet
prepared to do this) or silenceing. We have gone with the latter.

ref: jekyll/jekyll#7947
@zkamvar zkamvar mentioned this issue May 20, 2020
Closed
@leimao
Copy link

leimao commented Jun 7, 2020

This should not be closed until Ruby 2.7.0 is supported.

@ashmaroli
Copy link
Member

@leimao Deprecation warnings have been removed in versions v3.8.7 and v4.0.1.
Please update your program accordingly.

@leimao
Copy link

leimao commented Jun 7, 2020

@leimao Deprecation warnings have been removed in versions v3.8.7 and v4.0.1.
Please update your program accordingly.

Thank you. I did sudo bundle update jekyll and it seems that the warnings are gone.

@Atcold
Copy link

Atcold commented Jun 9, 2020

@leimao Deprecation warnings have been removed in versions v3.8.7 and v4.0.1.
Please update your program accordingly.

Thank you. I did sudo bundle update jekyll and it seems that the warnings are gone.

That did not work for me. gem update jekyll did the job, though.

@bhagatparwinder
Copy link

For me, neither of the above two commands worked (using Jekyll with GitHub pages).

Updated gemfile with github-pages to 206 and jekyll to 3.8.7. Executed bundle update jekyll.

Everything is hunky-dory now.

aljoscha added a commit to aljoscha/flink that referenced this issue Jun 19, 2020
@aljoscha
[FLINK-18381] Update Jekyll to 4.0.1
e090f55 
Building the docs with Ruby 2.7 and Jekyll 4.0.0 spits out a lot of
warnings, see jekyll/jekyll#7947. Updating to
4.0.1 fixes this.
aljoscha added a commit to apache/flink that referenced this issue Jun 22, 2020
@aljoscha
[FLINK-18381] Update Jekyll to 4.0.1
ea9ce92 
Building the docs with Ruby 2.7 and Jekyll 4.0.0 spits out a lot of
warnings, see jekyll/jekyll#7947. Updating to
4.0.1 fixes this.
aljoscha added a commit to apache/flink that referenced this issue Jun 22, 2020
@aljoscha
[FLINK-18381] Update Jekyll to 4.0.1
29daf12 
Building the docs with Ruby 2.7 and Jekyll 4.0.0 spits out a lot of
warnings, see jekyll/jekyll#7947. Updating to
4.0.1 fixes this.
zhangjun0x01 pushed a commit to zhangjun0x01/flink that referenced this issue Jul 8, 2020
@aljoscha
[FLINK-18381] Update Jekyll to 4.0.1
916cc1b 
Building the docs with Ruby 2.7 and Jekyll 4.0.0 spits out a lot of
warnings, see jekyll/jekyll#7947. Updating to
4.0.1 fixes this.
lin9long pushed a commit to lin9long/myflink that referenced this issue Aug 22, 2020
@aljoscha
[FLINK-18381] Update Jekyll to 4.0.1
de31c0b 
Building the docs with Ruby 2.7 and Jekyll 4.0.0 spits out a lot of
warnings, see jekyll/jekyll#7947. Updating to
4.0.1 fixes this.
@ronaldevers ronaldevers mentioned this issue Oct 18, 2020
Merged
@cseas cseas mentioned this issue Dec 24, 2020
Open
@jekyll jekyll locked and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
frozen-due-to-age internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attain Ruby 3.0 compatibility ashmaroli/jekyll
7 participants
@DirtyF @Atcold @jekyllbot @bhagatparwinder @eirannejad @ashmaroli @leimao