New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config include trailing slash #8113
Config include trailing slash #8113
Conversation
4ba5f97
to
bf91700
Compare
Hi @DirtyF, is there any problem with this pull request that needs to be fixed or something I should do? It is my first time going through the pull request workflow in OSS. Please feel free to let me know if I missed something. |
@billykong nope, we're good, we just need to take the time to review your submission. |
Thanks @DirtyF and @ashmaroli |
@billykong Can you test separately if the issue you're resolving here can be reproduced with Jekyll 3.8.6..? (Want to see if the issue is a regression in Jekyll 4.0).. |
Hi @ashmaroli , it can be reproduced in Jekyll 3.8.6 |
Thanks for testing with Jekyll 3.8.6 @billykong, So it is certain now that the bug existed prior to Jekyll 4.0 and Jekyll 3.8.6 馃憤 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @billykong
Thanks @billykong |
This is a 馃悰 bug fix.
Summary
include
in the configuration file should include directory when trailing slash is present, e.g.should include the directory
_pages/
if exists.The current behavior in the
master
is that including_pages
will include the directory while_pages/
does not.This PR check that
_pages/
matches a directory named_pages
but not file.Context
Resolves #7951