New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`jekyll build --plugins some_dir` always fails #993

Closed
xuhdev opened this Issue Apr 21, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@xuhdev

xuhdev commented Apr 21, 2013

When running the following commands:

jekyll build --plugins some_dir

it always fails:

/Users/hong/.rvm/gems/ruby-1.9.3-p392/gems/jekyll-1.0.0.rc1/lib/jekyll/site.rb:103:in `expand_path': can't convert true into String (TypeError)
    from /Users/hong/.rvm/gems/ruby-1.9.3-p392/gems/jekyll-1.0.0.rc1/lib/jekyll/site.rb:103:in `block in plugins_path'
    from /Users/hong/.rvm/gems/ruby-1.9.3-p392/gems/jekyll-1.0.0.rc1/lib/jekyll/site.rb:103:in `map'
    from /Users/hong/.rvm/gems/ruby-1.9.3-p392/gems/jekyll-1.0.0.rc1/lib/jekyll/site.rb:103:in `plugins_path'
    from /Users/hong/.rvm/gems/ruby-1.9.3-p392/gems/jekyll-1.0.0.rc1/lib/jekyll/site.rb:21:in `initialize'
    from /Users/hong/.rvm/gems/ruby-1.9.3-p392/gems/jekyll-1.0.0.rc1/lib/jekyll/commands/build.rb:5:in `new'
    from /Users/hong/.rvm/gems/ruby-1.9.3-p392/gems/jekyll-1.0.0.rc1/lib/jekyll/commands/build.rb:5:in `process'
    from /Users/hong/.rvm/gems/ruby-1.9.3-p392/gems/jekyll-1.0.0.rc1/bin/jekyll:59:in `block (2 levels) in <top (required)>'
    from /Users/hong/.rvm/gems/ruby-1.9.3-p392/gems/commander-4.1.3/lib/commander/command.rb:180:in `call'
    from /Users/hong/.rvm/gems/ruby-1.9.3-p392/gems/commander-4.1.3/lib/commander/command.rb:180:in `call'
    from /Users/hong/.rvm/gems/ruby-1.9.3-p392/gems/commander-4.1.3/lib/commander/command.rb:155:in `run'
    from /Users/hong/.rvm/gems/ruby-1.9.3-p392/gems/commander-4.1.3/lib/commander/runner.rb:402:in `run_active_command'
    from /Users/hong/.rvm/gems/ruby-1.9.3-p392/gems/commander-4.1.3/lib/commander/runner.rb:78:in `run!'
    from /Users/hong/.rvm/gems/ruby-1.9.3-p392/gems/commander-4.1.3/lib/commander/delegates.rb:11:in `run!'
    from /Users/hong/.rvm/gems/ruby-1.9.3-p392/gems/commander-4.1.3/lib/commander/import.rb:10:in `block in <top (required)>'

But if the plugin directory is specified in _config.yaml, everything is fine.

@parkr parkr closed this in 5a20fa4 Apr 22, 2013

@xuhdev

This comment has been minimized.

xuhdev commented Apr 23, 2013

@parkr
Your commit says

--plugins now accepts plugin directories

But in fact I got the same error message if I specify a plugin file.

@parkr

This comment has been minimized.

Member

parkr commented Apr 23, 2013

Using your clone of master? Can you show me the command and the stacktrace?

@xuhdev

This comment has been minimized.

xuhdev commented Apr 23, 2013

What I meant is, in the output of jekyll help:

--plugins PLUGINS_DIR1[,PLUGINS_DIR2[,...]]
    Plugins directory (defaults to ./_plugins)

It says that --plugins specifies directories. But in fact it works even you specify a plugin file. This is quite confusing.

@parkr

This comment has been minimized.

Member

parkr commented Apr 23, 2013

It does a glob include so it'd work on just files, but it's meant to be used to specify directories.

parkr added a commit that referenced this issue Apr 26, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.