New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch all exceptions, not just StandardError descendents #1007

Merged
merged 1 commit into from Apr 30, 2013

Conversation

Projects
None yet
3 participants
@michaelklishin

michaelklishin commented Apr 30, 2013

We've hit a few edge cases in Liquid/Markdown rendering
with http://clojurewerkz.org documentation sites.
They resulted in exceptions Jekyll silently swallowed because
they were not StandardException subclasses.

Michael Klishin
Catch all exceptions, not just StandardError descendents
We've hit a few edge cases in Liquid/Markdown rendering
with http://clojurewerkz.org documentation sites.
They resulted in exceptions Jekyll silently swallowed because
they were not StandardException subclasses.
@parkr

This comment has been minimized.

Member

parkr commented Apr 30, 2013

Reminded me of a post @nixterrimus wrote a long time ago on begin...rescue blocks. Thanks for this!

parkr added a commit that referenced this pull request Apr 30, 2013

Merge pull request #1007 from michaelklishin/patch-1
Catch all exceptions, not just StandardError descendents

@parkr parkr merged commit 1f02150 into jekyll:master Apr 30, 2013

1 check passed

default The Travis build passed
Details

parkr added a commit that referenced this pull request Apr 30, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.