New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse strings into Time objects for date-related parsing #1014

Merged
merged 2 commits into from May 5, 2013

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented May 4, 2013

Users can pass String representation of Times into our Date-related Liquid filters.

Utilizes Time#parse for flexibility of input. Any values which are valid there are valid here as well.

Fixes #997.

@parkr

This comment has been minimized.

Member

parkr commented May 4, 2013

With approval from @mattr-, I'll merge and include in 1.0.

@mattr-

This comment has been minimized.

Member

mattr- commented May 5, 2013

I went back several times on how to do this. I like what you put together quite a bit. It was much better than my version.

👍

parkr added a commit that referenced this pull request May 5, 2013

Merge pull request #1014 from mojombo/string-times
Parse strings into Time objects for date-related parsing

@parkr parkr merged commit dcf3911 into master May 5, 2013

1 check passed

default The Travis build passed
Details

@parkr parkr deleted the string-times branch May 5, 2013

parkr added a commit that referenced this pull request May 5, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.