New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use newer language-
class name prefix
#1037
Conversation
This change makes it partly possible to use Jekyll+RedCarpet+Prism.js without using a plugin. Another change will respect Jekyll's `pygments` configuration option and not render the code block using Pygments. Together, these two changes allow using prism.js with Jekyll out of the box.
I don't see a problem with this. 👍 from me. |
Neat, was looking to patch this in today myself. |
This is only one change. Where's the other? My biggest concern is that this breaks all the CSS styles people have written for custom code highlighting :/ No backwards-compatibility, unless you set |
The other one is in a separate pull-request ( #1038 ) because they can be seen separate. I agree with the backwards-compatibility point. Using both class names would be a sufficient solution. |
Great! Keep it backwards-compatible, fix the tests and we're good to go. |
Add newer `language-` class name prefix to code blocks
Any chance you can add a something like a code:before {
content: attr(class);
} |
The diff here doesn't reflect the changes entirely. We now use |
It ruined it because now I get |
Gah, sorry, I didn't even really process the code. Late-night brain mode :) I am weary about adding more attributes :/ |
Oh well, it was nice while it lasted. 😞 |
Tell you what: submit a PR and we'll talk it over with @mattr-. I may be weary, but I'm not opposed. :) |
Done #1066 |
This change makes it partly possible to use Jekyll+RedCarpet+Prism.js without using a plugin.
Another change will respect Jekyll's
pygments
configuration option and not render the code block using Pygments. Together, these two changes allow using prism.js with Jekyll out of the box.