New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'docs' subcommand #1046

Merged
merged 1 commit into from Jul 9, 2013

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented May 7, 2013

Launches documentation for current version of Jekyll for offline viewing.

Solves #1043.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 7, 2013

Member

Failing tests are unrelated to this change

Member

parkr commented May 7, 2013

Failing tests are unrelated to this change

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 7, 2013

Member

@mattr- Include this in 1.0.1 or wait?

Member

parkr commented May 7, 2013

@mattr- Include this in 1.0.1 or wait?

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- May 7, 2013

Member

I think I'd wait on 1.1 for this.

Member

mattr- commented May 7, 2013

I think I'd wait on 1.1 for this.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 7, 2013

Member

👍 Cool.

Member

parkr commented May 7, 2013

👍 Cool.

@tombell

This comment has been minimized.

Show comment
Hide comment
@tombell

tombell May 23, 2013

Contributor

This command doesn't make any sense. It implies that the 'uncompiled' docs are shipped in the gem. If you want to view the docs there is a Rake task already - https://github.com/mojombo/jekyll/blob/master/Rakefile#L92

Contributor

tombell commented May 23, 2013

This command doesn't make any sense. It implies that the 'uncompiled' docs are shipped in the gem. If you want to view the docs there is a Rake task already - https://github.com/mojombo/jekyll/blob/master/Rakefile#L92

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 23, 2013

Member

@tombell I was thinking that this would be for users of the Jekyll gem, so that they don't have to cd to the gem directory and run rake site:preview. :/

Member

parkr commented May 23, 2013

@tombell I was thinking that this would be for users of the Jekyll gem, so that they don't have to cd to the gem directory and run rake site:preview. :/

@tombell

This comment has been minimized.

Show comment
Hide comment
@tombell

tombell May 23, 2013

Contributor

I don't think the demand for 'offline' docs is there, especially ones you have to wait to generate yourself.

Contributor

tombell commented May 23, 2013

I don't think the demand for 'offline' docs is there, especially ones you have to wait to generate yourself.

@parkr parkr referenced this pull request Jul 9, 2013

Closed

Offline documentation #1288

parkr added a commit that referenced this pull request Jul 9, 2013

Merge pull request #1046 from mojombo/jekyll-docs
Add 'docs' subcommand. Solves #1043, solves #1288.

@parkr parkr merged commit 3209b50 into master Jul 9, 2013

1 check passed

default The Travis CI build passed
Details

@parkr parkr deleted the jekyll-docs branch Jul 9, 2013

parkr added a commit that referenced this pull request Jul 9, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.