Add 'docs' subcommand #1046

Merged
merged 1 commit into from Jul 9, 2013

Projects

None yet

3 participants

@parkr
Member
parkr commented May 7, 2013

Launches documentation for current version of Jekyll for offline viewing.

Solves #1043.

@parkr
Member
parkr commented May 7, 2013

Failing tests are unrelated to this change

@parkr
Member
parkr commented May 7, 2013

@mattr- Include this in 1.0.1 or wait?

@mattr-
Member
mattr- commented May 7, 2013

I think I'd wait on 1.1 for this.

@parkr
Member
parkr commented May 7, 2013

👍 Cool.

@tombell
Contributor
tombell commented May 23, 2013

This command doesn't make any sense. It implies that the 'uncompiled' docs are shipped in the gem. If you want to view the docs there is a Rake task already - https://github.com/mojombo/jekyll/blob/master/Rakefile#L92

@parkr
Member
parkr commented May 23, 2013

@tombell I was thinking that this would be for users of the Jekyll gem, so that they don't have to cd to the gem directory and run rake site:preview. :/

@tombell
Contributor
tombell commented May 23, 2013

I don't think the demand for 'offline' docs is there, especially ones you have to wait to generate yourself.

@parkr parkr referenced this pull request Jul 9, 2013
Closed

Offline documentation #1288

@parkr parkr merged commit 3209b50 into master Jul 9, 2013

1 check passed

default The Travis CI build passed
Details
@parkr parkr deleted the jekyll-docs branch Jul 9, 2013
@parkr parkr added a commit that referenced this pull request Jul 9, 2013
@parkr parkr Update history to reflect merge of #1046 f6db083
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment