Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'docs' subcommand #1046

Merged
merged 1 commit into from Jul 9, 2013
Merged

Add 'docs' subcommand #1046

merged 1 commit into from Jul 9, 2013

Conversation

@parkr
Copy link
Member

@parkr parkr commented May 7, 2013

Launches documentation for current version of Jekyll for offline viewing.

Solves #1043.

@parkr
Copy link
Member Author

@parkr parkr commented May 7, 2013

Failing tests are unrelated to this change

@parkr
Copy link
Member Author

@parkr parkr commented May 7, 2013

@mattr- Include this in 1.0.1 or wait?

@mattr-
Copy link
Member

@mattr- mattr- commented May 7, 2013

I think I'd wait on 1.1 for this.

@parkr
Copy link
Member Author

@parkr parkr commented May 7, 2013

👍 Cool.

@tombell
Copy link
Contributor

@tombell tombell commented May 23, 2013

This command doesn't make any sense. It implies that the 'uncompiled' docs are shipped in the gem. If you want to view the docs there is a Rake task already - https://github.com/mojombo/jekyll/blob/master/Rakefile#L92

@parkr
Copy link
Member Author

@parkr parkr commented May 23, 2013

@tombell I was thinking that this would be for users of the Jekyll gem, so that they don't have to cd to the gem directory and run rake site:preview. :/

@tombell
Copy link
Contributor

@tombell tombell commented May 23, 2013

I don't think the demand for 'offline' docs is there, especially ones you have to wait to generate yourself.

@parkr parkr mentioned this pull request Jul 9, 2013
parkr added a commit that referenced this pull request Jul 9, 2013
Add 'docs' subcommand. Solves #1043, solves #1288.
@parkr parkr merged commit 3209b50 into master Jul 9, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
@parkr parkr deleted the jekyll-docs branch Jul 9, 2013
parkr added a commit that referenced this pull request Jul 9, 2013
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.