Add 'docs' subcommand #1046
Merged
Add 'docs' subcommand #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing tests are unrelated to this change |
|
@mattr- Include this in 1.0.1 or wait? |
|
I think I'd wait on 1.1 for this. |
|
👍 Cool. |
|
This command doesn't make any sense. It implies that the 'uncompiled' docs are shipped in the gem. If you want to view the docs there is a Rake task already - https://github.com/mojombo/jekyll/blob/master/Rakefile#L92 |
|
@tombell I was thinking that this would be for users of the Jekyll gem, so that they don't have to |
|
I don't think the demand for 'offline' docs is there, especially ones you have to wait to generate yourself. |
Closed
parkr
added a commit
that referenced
this pull request
Jul 9, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launches documentation for current version of Jekyll for offline viewing.
Solves #1043.