New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect pygments config option in Redcarpet renderer. #1053

Merged
merged 4 commits into from May 7, 2013

Conversation

Projects
None yet
5 participants
@parkr
Member

parkr commented May 7, 2013

An alternative to #1038.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 7, 2013

Member

@mattr- All tests are now passing on my machine. What do you think of this? The @config isn't available to the subclass of Redcarpet::Render::HTML so this is what I did instead.

Member

parkr commented May 7, 2013

@mattr- All tests are now passing on my machine. What do you think of this? The @config isn't available to the subclass of Redcarpet::Render::HTML so this is what I did instead.

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- May 7, 2013

Member

👍 :shipit:

Member

mattr- commented May 7, 2013

👍 :shipit:

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 7, 2013

Member

😓 phew, the travis failure is just that weird cucumber stack trace thing. i'll run it again locally just to make sure it works, then i'll merge.

Member

parkr commented May 7, 2013

😓 phew, the travis failure is just that weird cucumber stack trace thing. i'll run it again locally just to make sure it works, then i'll merge.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 7, 2013

Member

Passed. Merging and I'll throw up 1.0.1.

Member

parkr commented May 7, 2013

Passed. Merging and I'll throw up 1.0.1.

parkr added a commit that referenced this pull request May 7, 2013

Merge pull request #1053 from mojombo/redcarpet-respect-pygments
Respect pygments config option in Redcarpet renderer.

@parkr parkr merged commit cb0054b into master May 7, 2013

1 check passed

default The Travis CI build passed
Details

@parkr parkr deleted the redcarpet-respect-pygments branch May 7, 2013

parkr added a commit that referenced this pull request May 7, 2013

@djui

This comment has been minimized.

Show comment
Hide comment
@djui

djui May 8, 2013

Contributor

@parkr Nice work. Thanks!

Contributor

djui commented May 8, 2013

@parkr Nice work. Thanks!

include WithoutPygments
end
end
rescue LoadErro

This comment has been minimized.

@maul-esel

maul-esel May 8, 2013

Contributor

typo?

@maul-esel

maul-esel May 8, 2013

Contributor

typo?

This comment has been minimized.

@parkr

parkr May 8, 2013

Member

yep, good catch :)

@parkr

parkr May 8, 2013

Member

yep, good catch :)

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.