Skip to content

/ jekyll

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect pygments config option in Redcarpet renderer. #1053

Merged
merged 4 commits into from May 7, 2013
Merged

Respect pygments config option in Redcarpet renderer. #1053

merged 4 commits into from May 7, 2013

Conversation

@parkr
Copy link
Member

@parkr parkr commented May 7, 2013

An alternative to #1038.
@parkr
Respect pygments config option in Redcarpet renderer.
Loading status checks…
2114bb3
@parkr parkr mentioned this pull request May 7, 2013
Closed
parkr added 3 commits May 7, 2013
@parkr
Using modules instead of classes for Redcarpet with/without Pygments.
Loading status checks…
62b4fd7
@parkr
fix up tests for pygments-aware redcarpet
f69c39c
@parkr
Properly wrap and encode non-pygmentized code.
Loading status checks…
739f752
@parkr
Copy link
Member Author

@parkr parkr commented May 7, 2013

@mattr- All tests are now passing on my machine. What do you think of this? The @config isn't available to the subclass of Redcarpet::Render::HTML so this is what I did instead.
@mattr-
Copy link
Member

@mattr- mattr- commented May 7, 2013

👍 :shipit:
@parkr
Copy link
Member Author

@parkr parkr commented May 7, 2013

😓 phew, the travis failure is just that weird cucumber stack trace thing. i'll run it again locally just to make sure it works, then i'll merge.
@parkr
Copy link
Member Author

@parkr parkr commented May 7, 2013

Passed. Merging and I'll throw up 1.0.1.
parkr added a commit that referenced this pull request May 7, 2013
@parkr
Merge pull request #1053 from mojombo/redcarpet-respect-pygments
Loading status checks…
cb0054b 
Respect pygments config option in Redcarpet renderer.
@parkr parkr merged commit cb0054b into master May 7, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
@parkr parkr deleted the redcarpet-respect-pygments branch May 7, 2013
parkr added a commit that referenced this pull request May 7, 2013
@parkr
Update history to reflect merge of #1053. Closes #1038.
Loading status checks…
2bee768
@djui
Copy link
Contributor

@djui djui commented May 8, 2013

@parkr Nice work. Thanks!
lib/jekyll/converters/markdown/redcarpet_parser.rb
include WithoutPygments
end
end
rescue LoadErro

This comment has been minimized.

Sign in to view
@maul-esel

maul-esel May 8, 2013

typo?

This comment has been minimized.

Sign in to view
@parkr

parkr May 8, 2013
Author Member

yep, good catch :)
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
1.0.1
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@parkr @mattr- @djui @maul-esel @jekyllbot
You can’t perform that action at this time.