New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added jekyll-contentblocks to the plugins list #1068

Merged
merged 1 commit into from May 14, 2013

Conversation

Projects
None yet
5 participants
@rustygeldmacher

rustygeldmacher commented May 9, 2013

Hi there, I added my plugin, jekyll-contentblocks, to the list of plugins. Thanks!

@zachgersh

This comment has been minimized.

Contributor

zachgersh commented May 14, 2013

@parkr should merge this easy one :)

@parkr

This comment has been minimized.

Member

parkr commented May 14, 2013

I'm still torn on what we want to do about plugins. Accept them all? Have a review process? Not change them from where they are? @mattr-, what do you think?

@zachgersh

This comment has been minimized.

Contributor

zachgersh commented May 14, 2013

I can definitely see plugin review being a good thing but it will be very time consuming and it begs the question of how to review.

Here is my question to you. Do we actually start to take some plugin functionality and roll it into core?

I think for now we create a plugin page, list all of them and put a giant warning at the top of Jekyllrb that says these are not supported by the Jekyll maintainers.

On May 14, 2013, at 11:19 AM, Parker Moore notifications@github.com wrote:

I'm still torn on what we want to do about plugins. Accept them all? Have a review process? Not change them from where they are? @mattr-, what do you think?


Reply to this email directly or view it on GitHub.

@parkr

This comment has been minimized.

Member

parkr commented May 14, 2013

I guess we'd add it to Jekyll core if it were submitted as a PR and/or was heavily requested for use on GH Pages natively and is safe to run on GH's servers. If it's really awesome functionality, we'd probably roll it in if it's feasible to do so.

Good idea about the warning.

@mattr-

This comment has been minimized.

Member

mattr- commented May 14, 2013

I'm with @zachgersh. Let's merge anything into the docs that we get a PR for and evaluate specific plugins at the time that they're asked to be moved into Jekyll core.

parkr added a commit that referenced this pull request May 14, 2013

@parkr parkr merged commit 1646c22 into jekyll:master May 14, 2013

1 check passed

default The Travis CI build passed
Details
@rustygeldmacher

This comment has been minimized.

rustygeldmacher commented May 15, 2013

Thanks guys! If anyone feels like reviewing and letting me know if there's a better/smarter way to do this, I'm all for it :) Also, if you think this is something that could go into core, I'm definitely game to help prepare it for that.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.