New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate old config 'server_port' #1084

Merged
merged 3 commits into from May 12, 2013

Conversation

Projects
None yet
4 participants
@maul-esel
Contributor

maul-esel commented May 11, 2013

This deprecates the no longer used server_port config option and fixes #1050.

Show outdated Hide outdated lib/jekyll/configuration.rb
@@ -164,6 +164,15 @@ def backwards_compatibilize
config.delete('server')
end
if config.has_key? 'server_port'
Jekyll::Logger.warn "Deprecation:", "The 'server_port' configuration option" +
" has been renamed to 'port'. Update your config file" +

This comment has been minimized.

@parkr

parkr May 11, 2013

Member

Can you add a please here, please? :)

@parkr

parkr May 11, 2013

Member

Can you add a please here, please? :)

Show outdated Hide outdated lib/jekyll/configuration.rb
" has been renamed to 'port'. Update your config file" +
" accordingly."
# copy but don't overwrite:
config['port'] = config['server_port'] unless config.has_key?('port')

This comment has been minimized.

@parkr

parkr May 11, 2013

Member

smart to preserve the old one :)

@parkr

parkr May 11, 2013

Member

smart to preserve the old one :)

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 11, 2013

Member

You rock. 👍 from me! Just need @mattr-'s approval and we can merge. :)

Member

parkr commented May 11, 2013

You rock. 👍 from me! Just need @mattr-'s approval and we can merge. :)

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- May 12, 2013

Member

looks ok to me. 👍

Member

mattr- commented May 12, 2013

looks ok to me. 👍

parkr added a commit that referenced this pull request May 12, 2013

@parkr parkr merged commit 9140aad into jekyll:master May 12, 2013

1 check passed

default The Travis CI build passed
Details

@maul-esel maul-esel deleted the maul-esel:deprecate-old-config branch May 12, 2013

parkr added a commit that referenced this pull request May 12, 2013

@parkr parkr referenced this pull request May 12, 2013

Closed

server_port deprecated? #1050

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.