Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Adds margin to code highlights. Tweaks colorscheme of notes. #1089
Screenshot from the other thread, for reference:
Yep, font-size and padding/margin are a definite improvement. As for the actual color of the code element though, I think this needs to be tailored a bit more to each of the different note types (i.e. dark red/blue/brown) instead of just being an unsaturated grey. It might be possible to do with this a partial transparency (i.e.
@zachgersh I still think the contrast is way too much. Ideally we want this to be reasonably subtle, so that it looks like it’s just recessed a little bit into the blue flag/ribbon section. Here’s a quick stab at tweaking things just in webinspector to show you what I mean:
Also, I noticed that in your latest screenshot, the