Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Jekyll::Logger ~> Jekyll::Stevenson to fix inheritance problem #1106

Merged
merged 1 commit into from May 14, 2013

Conversation

Projects
None yet
4 participants
@parkr
Copy link
Member

parkr commented May 14, 2013

Problem described here: ca888ca

parkr referenced this pull request May 14, 2013

When pygments is required after Jekyll::Logger is required, its inter…
…nal require to Ruby's stdlib Logger class chokes. This is an ugly-ass work-around.
@mattr-

This comment has been minimized.

Copy link
Member

mattr- commented May 14, 2013

👍

On Tue, May 14, 2013 at 2:07 PM, Parker Moore notifications@github.comwrote:

Problem described here: ca888cahttps://github.com/mojombo/jekyll/commit/ca888cad76b7816bbe3b004b0b9e7064cfb5215b

You can merge this Pull Request by running

git pull https://github.com/mojombo/jekyll stevenson

Or view, comment on, or merge it at:

#1106
Commit Summary

  • Rename Jekyll::Logger ~> Jekyll::Stevenson to fix inheritance problem

File Changes

  • M lib/jekyll/command.rbhttps://github.com//pull/1106/files#diff-0(6)
  • M lib/jekyll/commands/build.rbhttps://github.com//pull/1106/files#diff-1(10)
  • M lib/jekyll/commands/doctor.rbhttps://github.com//pull/1106/files#diff-2(4)
  • M lib/jekyll/commands/new.rbhttps://github.com//pull/1106/files#diff-3(2)
  • M lib/jekyll/configuration.rbhttps://github.com//pull/1106/files#diff-4(12)
  • M lib/jekyll/convertible.rbhttps://github.com//pull/1106/files#diff-5(2)
  • M lib/jekyll/deprecator.rbhttps://github.com//pull/1106/files#diff-6(4)
  • M lib/jekyll/filters.rbhttps://github.com//pull/1106/files#diff-7(2)
  • M lib/jekyll/logger.rbhttps://github.com//pull/1106/files#diff-8(2)
  • M lib/jekyll/site.rbhttps://github.com//pull/1106/files#diff-9(4)

Patch Links:

parkr added a commit that referenced this pull request May 14, 2013

Merge pull request #1106 from mojombo/stevenson
Rename Jekyll::Logger ~> Jekyll::Stevenson to fix inheritance problem

@parkr parkr merged commit e71e90c into master May 14, 2013

1 check passed

default The Travis CI build passed
Details

@parkr parkr deleted the stevenson branch May 14, 2013

parkr added a commit that referenced this pull request May 14, 2013

@brainkim

This comment has been minimized.

Copy link
Contributor

brainkim commented May 15, 2013

Why does Stevenson inherit from Logger? Stevenson is a bunch of methods grouped as class methods, while Logger usually requires instantiation (i.e. Logger.new(STDOUT)) so you actually haven't overwritten any of the inherited methods. Is there any reason to inherit from Logger other than to show intent?
http://www.ruby-doc.org/stdlib-2.0/libdoc/logger/rdoc/Logger.html

@parkr

This comment has been minimized.

Copy link
Member Author

parkr commented May 15, 2013

You're right - I meant to get rid of that inheritance.

parkr added a commit that referenced this pull request May 15, 2013

@brainkim

This comment has been minimized.

Copy link
Contributor

brainkim commented May 15, 2013

Thanks for the reply. BTW 1.0 is great!

@parkr

This comment has been minimized.

Copy link
Member Author

parkr commented May 15, 2013

Glad you like it!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.