Backwards-compatibilize 'exclude' and 'include' config tags #1114

Merged
merged 2 commits into from May 18, 2013

Projects

None yet

2 participants

@parkr
Member
parkr commented May 15, 2013

Fixes #1109.

@mattr-
Member
mattr- commented May 16, 2013

👍

@mattr-
Member
mattr- commented May 16, 2013

Stop the presses! No tests for this?

@parkr
Member
parkr commented May 17, 2013

@mattr- Tests done :)

@parkr
Member
parkr commented May 17, 2013

Also, thinking of the LSI output, it might make sense to have all logs go to $stderr. :/

@mattr- mattr- commented on the diff May 18, 2013
test/test_configuration.rb
@@ -51,9 +51,11 @@ class TestConfiguration < Test::Unit::TestCase
context "#backwards_compatibilize" do
setup do
@config = Configuration[{
- "auto" => true,
- "watch" => true,
- "server" => true
+ "auto" => true,
+ "watch" => true,
+ "server" => true,
+ "exclude" => "READ-ME.md, Gemfile,CONTRIBUTING.hello.markdown",
+ "include" => "STOP_THE_PRESSES.txt,.heloses, .git"
@mattr-
mattr- May 18, 2013 Member

👍 🤘 ❤️

@mattr-
Member
mattr- commented May 18, 2013

I am Matt Rogers and I approve this pull request.

@mattr- mattr- merged commit ddba4cd into master May 18, 2013

1 check passed

default The Travis CI build passed
Details
@mattr- mattr- deleted the backwards-compatibilize-exclude-include branch May 18, 2013
@mattr- mattr- added a commit that referenced this pull request May 18, 2013
@mattr- mattr- Update history to reflect merge of #1114 6a7ed52
@parkr
Member
parkr commented May 18, 2013

lolololol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment