New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non zero exit on Liquid exception #1121

Merged
merged 2 commits into from May 18, 2013

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented May 17, 2013

Related to #1110.

/cc @benbalter

@benbalter

This comment has been minimized.

Show comment
Hide comment
@benbalter

benbalter May 17, 2013

Contributor

👍 to confirm, will this 💩 out every time Maruku doesn't like ill-structured markdown?

Contributor

benbalter commented May 17, 2013

👍 to confirm, will this 💩 out every time Maruku doesn't like ill-structured markdown?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 17, 2013

Member

nothing on markdown errors in this one, but this fulfills the liquid parsing issues piece of the request :)

Member

parkr commented May 17, 2013

nothing on markdown errors in this one, but this fulfills the liquid parsing issues piece of the request :)

@benbalter

This comment has been minimized.

Show comment
Hide comment
@benbalter

benbalter May 17, 2013

Contributor

:shipit:

Contributor

benbalter commented May 17, 2013

:shipit:

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 17, 2013

Member

Cool! @mattr- if you think this is appropriate for 1.0.3, :shipit: :)

Member

parkr commented May 17, 2013

Cool! @mattr- if you think this is appropriate for 1.0.3, :shipit: :)

mattr- added a commit that referenced this pull request May 18, 2013

@mattr- mattr- merged commit 2b84173 into master May 18, 2013

1 check passed

default The Travis CI build passed
Details

mattr- added a commit that referenced this pull request May 18, 2013

@mattr- mattr- deleted the non-zero-exit-on-liquid-exception branch May 18, 2013

@parkr parkr referenced this pull request May 18, 2013

Closed

Better Converter Feedback #1105

3 of 5 tasks complete

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.