Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #622 (Cucumber infinite loop) #1139

Merged
merged 2 commits into from May 23, 2013

Conversation

Projects
None yet
5 participants
@scribu
Copy link
Contributor

scribu commented May 23, 2013

#622

Unit test assertions seem to be baked into Cucumber by default now.

@mattr-

This comment has been minimized.

Copy link
Member

mattr- commented May 23, 2013

This makes all the tests on Travis fail with the following error

NameError: uninitialized constant Test::Unit::AssertionFailedError

How do we get around the infinite loop and make these errors go away?

@maul-esel

This comment has been minimized.

Copy link
Contributor

maul-esel commented May 23, 2013

@mattr-: the error you mention also occurs before this change, e.g. https://travis-ci.org/mojombo/jekyll/jobs/7408093

@scribu

This comment has been minimized.

Copy link
Contributor Author

scribu commented May 23, 2013

Yeah, if I run rake locally, it works fine.

@maul-esel

This comment has been minimized.

Copy link
Contributor

maul-esel commented May 23, 2013

I think someone recently mentioned in one of your PRs that the error is caused by a broken version of the rr gem.

@mattr-

This comment has been minimized.

Copy link
Member

mattr- commented May 23, 2013

ahh, so it does. that makes me 😭

@mattr-

This comment has been minimized.

Copy link
Member

mattr- commented May 23, 2013

Ok, fixed that stupid issue. 👍 from me. Your turn @parkr 😃

scribu added some commits May 23, 2013

make bin/jekyll executable
`bundle install` makes it executable and it should be anyway, since it
has the hashbang at the top.
cucumber: don't manually include assertions
It causes hard to debug infinite loops and it's done automatically
in recent versions of Cucumber anyway.
@scribu

This comment has been minimized.

Copy link
Contributor Author

scribu commented May 23, 2013

Rebased to include 5cc65de (Travis build passes now).

@parkr

This comment has been minimized.

Copy link
Member

parkr commented May 23, 2013

👍 🤘 🍨 thanks @scribu! You rock!

parkr added a commit that referenced this pull request May 23, 2013

Merge pull request #1139 from scribu/cucumber-fix
Fix for #622 (Cucumber infinite loop)

@parkr parkr merged commit 4b6baf0 into jekyll:master May 23, 2013

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request May 23, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.