New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0 introduces several new config file options, added a note to Upgrade page about this #1146

Merged
merged 1 commit into from Jun 1, 2013

Conversation

Projects
None yet
4 participants
@beeeswax
Contributor

beeeswax commented May 24, 2013

I was using "host" or "url" in the config.yml to do something in a pre-1.0 jekyll site. When I upgraded, stuff broke with no explanation. Adding this note to the Upgrade page to help others. (See #1031)

Thanks!
MM

@parkr

This comment has been minimized.

Member

parkr commented May 24, 2013

👍 from me! @mattr-?

@mattr-

This comment has been minimized.

Member

mattr- commented May 25, 2013

I'm not ok with this in its current form. It's using the wrong filename for the page and when I patch it manually, it messes up the page.

screen shot 2013-05-24 at 10 50 57 pm

Once these issues are fixed, I'll re-review it. 😃

@beeeswax

This comment has been minimized.

Contributor

beeeswax commented May 25, 2013

Weird! These pages stopped being posts and started being pages somewhere between then and now. 😄 I'll try to figure out what's going on.

@beeeswax

This comment has been minimized.

Contributor

beeeswax commented May 25, 2013

Okay, I think/hope this fixes both issues. The page is in the new docs directory, and it seems to be building properly.

Thanks!
MM

parkr added a commit that referenced this pull request Jun 1, 2013

@parkr parkr merged commit e990229 into jekyll:master Jun 1, 2013

1 check passed

default The Travis CI build passed
Details

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.