New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Jekyll.logger instead of Jekyll::Stevenson to log things #1149

Merged
merged 2 commits into from May 29, 2013

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented May 25, 2013

Gives us more control over the log level, and we can handle new input via buffers (for example) so we know when to add newlines, etc.

I wasn't feeling too happy with Ruby's built-in Logger class (due to the formatting we have in place and the difficulty with overriding its methods to color the output) so I did this instead.

/cc @mattr-

@mattr-

This comment has been minimized.

Member

mattr- commented May 29, 2013

Looks good. The docs change looks unrelated though. Could it be removed before merging?

@parkr

This comment has been minimized.

Member

parkr commented May 29, 2013

Removed the docs change - merging.

parkr added a commit that referenced this pull request May 29, 2013

Merge pull request #1149 from mojombo/jekyll-logger
Use Jekyll.logger instead of Jekyll::Stevenson to log things

@parkr parkr merged commit 21c153a into master May 29, 2013

@parkr parkr deleted the jekyll-logger branch May 29, 2013

parkr added a commit that referenced this pull request May 29, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.