Moved backwards_compatibilize into deprecator #1163

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
5 participants
@jpiasetz
Contributor

jpiasetz commented May 29, 2013

I'm on the fence about whether this is a good idea.

Pros

  • Makes Configuration read exactly the current state of jekyll
  • Collects all the backwards compatible code in one place

Cons

  • Adds complexity
@parkr

This comment has been minimized.

Show comment Hide comment
@parkr

parkr May 29, 2013

Member

Moving code that defines (part of) the Configuration class out of configuration.rb is something I'd like to avoid. I can see this becoming a class method of Deprecator that is then used by Configuration, but I'm not sure. Thanks for the suggestion though.

Member

parkr commented May 29, 2013

Moving code that defines (part of) the Configuration class out of configuration.rb is something I'd like to avoid. I can see this becoming a class method of Deprecator that is then used by Configuration, but I'm not sure. Thanks for the suggestion though.

@jpiasetz jpiasetz closed this May 29, 2013

@parkr

This comment has been minimized.

Show comment Hide comment
@parkr

parkr May 29, 2013

Member

I'd love to get @mattr-'s take on this.

Member

parkr commented May 29, 2013

I'd love to get @mattr-'s take on this.

@mattr-

This comment has been minimized.

Show comment Hide comment
@mattr-

mattr- Jun 2, 2013

Member

@jpiasetz A valiant attempt!

To reduce the complexity, I'd implement individual objects for each option that is backwards incompatible and use those objects to remove all the various conditionals, since they all have the same pattern. It would be awesome if you could submit a pull request that implements something like that.

Member

mattr- commented Jun 2, 2013

@jpiasetz A valiant attempt!

To reduce the complexity, I'd implement individual objects for each option that is backwards incompatible and use those objects to remove all the various conditionals, since they all have the same pattern. It would be awesome if you could submit a pull request that implements something like that.

@jpiasetz jpiasetz reopened this Jun 4, 2013

@jpiasetz

This comment has been minimized.

Show comment Hide comment
@jpiasetz

jpiasetz Jun 4, 2013

Contributor

@mattr- I'll take a stab at making an object for them.

Contributor

jpiasetz commented Jun 4, 2013

@mattr- I'll take a stab at making an object for them.

@jpiasetz jpiasetz referenced this pull request Jul 9, 2013

Closed

Don't do things unless asked #1276

1 of 2 tasks complete
@kelvinst

This comment has been minimized.

Show comment Hide comment
@kelvinst

kelvinst Jul 11, 2013

So @jpiasetz, I'm working in some changes in Deprecator class, for doing this same thing (I didn't see your old pull request)... I'm just documenting the code and will pull request it soon...

So @jpiasetz, I'm working in some changes in Deprecator class, for doing this same thing (I didn't see your old pull request)... I'm just documenting the code and will pull request it soon...

@jpiasetz

This comment has been minimized.

Show comment Hide comment
@jpiasetz

jpiasetz Jul 11, 2013

Contributor

@kelvinst excellent. I got bog down on how to implement this.

Contributor

jpiasetz commented Jul 11, 2013

@kelvinst excellent. I got bog down on how to implement this.

@kelvinst

This comment has been minimized.

Show comment Hide comment
@kelvinst

kelvinst Jul 26, 2013

@mattr-, in #1357 I tried to do what you asking here, can you take a look?

@mattr-, in #1357 I tried to do what you asking here, can you take a look?

@parkr parkr closed this Mar 17, 2014

@parkr parkr reopened this Mar 17, 2014

@jpiasetz

This comment has been minimized.

Show comment Hide comment
@jpiasetz

jpiasetz Mar 19, 2014

Contributor

@mattr- or @parkr should I kill this in lieu of #1357's death?

Contributor

jpiasetz commented Mar 19, 2014

@mattr- or @parkr should I kill this in lieu of #1357's death?

@mattr-

This comment has been minimized.

Show comment Hide comment
@mattr-

mattr- Mar 19, 2014

Member

For now, I think that's probably best.

Member

mattr- commented Mar 19, 2014

For now, I think that's probably best.

@mattr- mattr- closed this Mar 19, 2014

@jpiasetz jpiasetz deleted the jpiasetz:Deprecation branch Mar 19, 2014

@jekyllbot jekyllbot locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.