Support new private gist syntax. #1189
Merged
Conversation
|
||
context "when invalid" do | ||
setup do | ||
@gist = "mattr-24081a1d93d2898ecf0f" |
mattr-
Jun 7, 2013
Member
shouldn't this be
@gist = "mattr-/24081a1d93d2898ecf0f"
?
(Notice the added slash)
shouldn't this be
@gist = "mattr-/24081a1d93d2898ecf0f"
?
(Notice the added slash)
mattr-
Jun 7, 2013
Member
ok, this is fine as is. never mind.
ok, this is fine as is. never mind.
parkr
Jun 7, 2013
Author
Member
haha it's supposed to be invalid! :)
haha it's supposed to be invalid! :)
LGTY @mattr-? |
|
parkr
added a commit
that referenced
this pull request
Jun 7, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Solves #1185.