Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new private gist syntax. #1189

Merged
merged 1 commit into from Jun 7, 2013
Merged

Support new private gist syntax. #1189

merged 1 commit into from Jun 7, 2013

Conversation

parkr
Copy link
Member

@parkr parkr commented Jun 6, 2013

Solves #1185.


context "when invalid" do
setup do
@gist = "mattr-24081a1d93d2898ecf0f"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be

@gist = "mattr-/24081a1d93d2898ecf0f"

?
(Notice the added slash)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, this is fine as is. never mind.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha it's supposed to be invalid! :)

@parkr
Copy link
Member Author

parkr commented Jun 7, 2013

LGTY @mattr-?

@mattr-
Copy link
Member

mattr- commented Jun 7, 2013

👍 :shipit:

parkr added a commit that referenced this pull request Jun 7, 2013
@parkr parkr merged commit 86e5a1f into master Jun 7, 2013
@parkr parkr deleted the private-gist-support branch June 7, 2013 18:55
parkr added a commit that referenced this pull request Jun 7, 2013
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants