/jekyll

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new private gist syntax. #1189

Merged
merged 1 commit into from Jun 7, 2013

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@parkr @mattr- @jekyllbot
@parkr
Member

parkr commented Jun 6, 2013

Solves #1185.
test/test_tags.rb
context "when invalid" do
setup do
@gist = "mattr-24081a1d93d2898ecf0f"

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Jun 7, 2013

Member

shouldn't this be

@gist = "mattr-/24081a1d93d2898ecf0f"

?
(Notice the added slash)
@mattr-

mattr- Jun 7, 2013

Member

shouldn't this be

@gist = "mattr-/24081a1d93d2898ecf0f"

?
(Notice the added slash)

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Jun 7, 2013

Member

ok, this is fine as is. never mind.
@mattr-

mattr- Jun 7, 2013

Member

ok, this is fine as is. never mind.

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 7, 2013

Member

haha it's supposed to be invalid! :)
@parkr

parkr Jun 7, 2013

Member

haha it's supposed to be invalid! :)
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 7, 2013

Member

LGTY @mattr-?
Member

parkr commented Jun 7, 2013

LGTY @mattr-?
@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Jun 7, 2013

Member

👍 :shipit:
Member

mattr- commented Jun 7, 2013

👍 :shipit:

parkr added a commit that referenced this pull request Jun 7, 2013

@parkr
Merge pull request #1189 from mojombo/private-gist-support 
Support new private gist syntax.
86e5a1f

@parkr parkr merged commit 86e5a1f into master Jun 7, 2013
1 check passed

1 check passed

default The Travis CI build passed
Details

@parkr parkr deleted the private-gist-support branch Jun 7, 2013

parkr added a commit that referenced this pull request Jun 7, 2013

@parkr
Update history to reflect merge of #1189. Solves #1185.
3214358

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

@jekyllbot jekyllbot added the frozen-due-to-age label Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.