Support new private gist syntax. #1189

Merged
merged 1 commit into from Jun 7, 2013

Projects

None yet

2 participants

@parkr
Member
parkr commented Jun 6, 2013

Solves #1185.

@mattr- mattr- commented on the diff Jun 7, 2013
test/test_tags.rb
+ title: My Cool Gist
+ ---
+
+ {% gist #{@gist} #{@filename} %}
+CONTENT
+ create_post(content, {'permalink' => 'pretty', 'source' => source_dir, 'destination' => dest_dir, 'read_posts' => true})
+ end
+
+ should "write script tag with specific file in gist" do
+ assert_match "<script src='https://gist.github.com/#{@gist}.js?file=#{@filename}'>\s</script>", @result
+ end
+ end
+
+ context "when invalid" do
+ setup do
+ @gist = "mattr-24081a1d93d2898ecf0f"
@mattr-
mattr- Jun 7, 2013 Member

shouldn't this be

@gist = "mattr-/24081a1d93d2898ecf0f"

?
(Notice the added slash)

@mattr-
mattr- Jun 7, 2013 Member

ok, this is fine as is. never mind.

@parkr
parkr Jun 7, 2013 Member

haha it's supposed to be invalid! :)

@parkr
Member
parkr commented Jun 7, 2013

LGTY @mattr-?

@mattr-
Member
mattr- commented Jun 7, 2013

👍 :shipit:

@parkr parkr merged commit 86e5a1f into master Jun 7, 2013

1 check passed

default The Travis CI build passed
Details
@parkr parkr deleted the private-gist-support branch Jun 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment