Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pagination #1198

Merged
merged 8 commits into from Jun 23, 2013
Merged

Fix Pagination #1198

merged 8 commits into from Jun 23, 2013

Conversation

parkr
Copy link
Member

@parkr parkr commented Jun 9, 2013

New: Look for an index.html page starting in the paginate_path and searching upward (in the FS tree) until an index.html is found.

  • paginate in subdirectories properly
  • traverse hierarchy (vertically) to find proper index.html file
  • add tests for new cases
  • fix tests for internals that were changed

@parkr
Copy link
Member Author

parkr commented Jun 9, 2013

@mattr- this is ready for review :)

@@ -29,7 +29,7 @@ class Configuration < Hash
'baseurl' => '/',
'include' => ['.htaccess'],
'exclude' => [],
'paginate_path' => 'page:num',
'paginate_path' => '/page:num',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing some context for this change. How is the added slash significant here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not significant as far as I know.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just testing with both :)

@parkr
Copy link
Member Author

parkr commented Jun 22, 2013

@mattr- – Any further comments? I think I'd like to hold off on the URL Helper for a different PR.

@mattr-
Copy link
Member

mattr- commented Jun 23, 2013

I'm cool with that. :shipit: 👍

On Sat, Jun 22, 2013 at 10:08 AM, Parker Moore notifications@github.com
wrote:

@mattr- – Any further comments? I think I'd like to hold off on the URL Helper for a different PR.

Reply to this email directly or view it on GitHub:
#1198 (comment)

parkr added a commit that referenced this pull request Jun 23, 2013
@parkr parkr merged commit f9d1739 into master Jun 23, 2013
@parkr parkr deleted the fix-pagination branch June 23, 2013 13:05
parkr added a commit that referenced this pull request Jun 23, 2013
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants