New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Markdown template parser for new sites to RedCarpet #1245

Merged
merged 1 commit into from Jun 27, 2013

Conversation

Projects
None yet
6 participants
@parkr
Member

parkr commented Jun 27, 2013

Done via generated _config.yml.

Related to #1236.

@parkr

This comment has been minimized.

Member

parkr commented Jun 27, 2013

@mattr- 😄

@mattr-

This comment has been minimized.

Member

mattr- commented Jun 27, 2013

Now I rule all the blogs!. 💥

😉

@zachgersh

This comment has been minimized.

Contributor

zachgersh commented Jun 27, 2013

Hey @parkr before we merge this can I also suggest that we update the documentation to mention the fact that the default for new is now RedCarpet?

mattr- added a commit that referenced this pull request Jun 27, 2013

Merge pull request #1245 from mojombo/jekyll-new-redcarpet
Default Markdown template parser for new sites to RedCarpet

@mattr- mattr- merged commit c5bf134 into master Jun 27, 2013

1 check passed

default The Travis CI build passed
Details

@mattr- mattr- deleted the jekyll-new-redcarpet branch Jun 27, 2013

@zachgersh

This comment has been minimized.

Contributor

zachgersh commented Jun 27, 2013

Annnnddddddd it's merged LOL

@parkr

This comment has been minimized.

Member

parkr commented Jun 27, 2013

@mattr-'s on a plane. He might not have gotten that :)

The default for all Jekyll sites will still be MaRuKu.

@mattr-

This comment has been minimized.

Member

mattr- commented Jun 27, 2013

Uno momento, por favor

On Thu, Jun 27, 2013 at 12:28 PM, Parker Moore notifications@github.comwrote:

@mattr- https://github.com/mattr-'s on a plane. He might not have
gotten that :)

The default for all Jekyll sites will still be MaRuKu.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1245#issuecomment-20141202
.

@zachgersh

This comment has been minimized.

Contributor

zachgersh commented Jun 27, 2013

Right, but shouldn't we explain that the site template when you use jekyll new will use a completely different pre-processor? Seems like we could just mention it in the quick-start as one of our nice info boxes :)

@mattr-

This comment has been minimized.

Member

mattr- commented Jun 27, 2013

We should probably also install redcarpet by default since new sites won't
work out of the box without it.

On Thu, Jun 27, 2013 at 12:32 PM, Zach notifications@github.com wrote:

Right, but shouldn't we explain that the site template when you use jekyll
new will use a completely different pre-processor? Seems like we could just
mention it in the quick-start as one of our nice info boxes :)


Reply to this email directly or view it on GitHubhttps://github.com//pull/1245#issuecomment-20141447
.

@mattr- mattr- restored the jekyll-new-redcarpet branch Jun 27, 2013

mattr- added a commit that referenced this pull request Jun 27, 2013

@doktorbro

This comment has been minimized.

Member

doktorbro commented Aug 15, 2013

Should Jekyll’s official site not be a role model and use Redcarpet as default markdown engine? Dogfooding is convincing.

@parkr

This comment has been minimized.

Member

parkr commented Aug 15, 2013

We need to maintain header links, e.g. Writing posts = #writing_posts, which RedCarpet (to my knowledge) doesn't support in 2.x.

@mattr-

This comment has been minimized.

Member

mattr- commented Aug 16, 2013

correct. it won't support that until 3.1.

On Thu, Aug 15, 2013 at 5:26 PM, Parker Moore notifications@github.comwrote:

We need to maintain header links, e.g. Writing posts = #writing_posts,
which RedCarpet (to my knowledge) doesn't support in 2.x.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1245#issuecomment-22735419
.

@malinow

This comment has been minimized.

malinow commented Nov 21, 2013

Hi friends!

On http://jekyllrb.com/docs/configuration/#default_configuration, it says: markdown: maruku (a.k.a. maruku is default parser).

Just confirming this should be redcarpet now? I'll fix it if so.

Thanks!
Matt

@parkr

This comment has been minimized.

Member

parkr commented Nov 21, 2013

Nope, the programmatic default is still maruku, but when you generate a site with jekyll new, you'll see markdown: redcarpet in your _config.yml. :)

@malinow

This comment has been minimized.

malinow commented Nov 21, 2013

Understood! Thanks @parkr. 👍

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.