New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News responsivityness #1286

Merged
merged 5 commits into from Jul 8, 2013

Conversation

Projects
None yet
4 participants
@cobyism
Member

cobyism commented Jul 8, 2013

This is #1285, but with master as the merge target. Just a few quick improvements to how the addition of this new news section affects smaller screens.

/cc @mattr- @parkr

@mattr-

This comment has been minimized.

Member

mattr- commented Jul 8, 2013

I just found this weird boundary case with the browser resizing. Is it worth it to fix it?
small-bad-wrapping

@cobyism

This comment has been minimized.

Member

cobyism commented Jul 8, 2013

Ah yep, I see that too. It looks like it only occurs between ~601px and 568px, and while there’s always the chance something will have a screen size between those values, none of the popular devices I’m aware of would be affected by that. My temptation would be to say to ignore that particular boundary-case.

@mattr-

This comment has been minimized.

Member

mattr- commented Jul 8, 2013

🔨 Works for me.

parkr added a commit that referenced this pull request Jul 8, 2013

@parkr parkr merged commit dca7158 into jekyll:master Jul 8, 2013

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jul 8, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.