New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The jekyll-s3 project was renamed to s3_website #1294

Merged
merged 2 commits into from Jul 10, 2013

Conversation

Projects
None yet
5 participants
@kewljedi
Contributor

kewljedi commented Jul 10, 2013

Wanted to make sure that the documentation doesn't send someone to a page that says to use something else. See https://github.com/laurilehmijoki/jekyll-s3 which says to goto https://github.com/laurilehmijoki/s3_website.

kewljedi added some commits Jul 10, 2013

The jekyll-s3 github page says that it is no longer being maintained …
…and that s3-website is the replacement, so I made changes to reflect that.
@parkr

This comment has been minimized.

Member

parkr commented Jul 10, 2013

👍 LGTM. @mattr-?

mattr- added a commit that referenced this pull request Jul 10, 2013

Merge pull request #1294 from kewljedi/gh-pages
The jekyll-s3 project was renamed to s3_website

@mattr- mattr- merged commit f9b61aa into jekyll:gh-pages Jul 10, 2013

@mattr-

This comment has been minimized.

Member

mattr- commented Jul 10, 2013

undo! undo! totally didn't see that this wasn't on master. le sigh.

mattr- added a commit that referenced this pull request Jul 10, 2013

Revert "Merge pull request #1294 from kewljedi/gh-pages"
This reverts commit f9b61aa, reversing
changes made to d6ee980.
@kewljedi

This comment has been minimized.

Contributor

kewljedi commented Jul 10, 2013

The merge was reverted and the pull request left closed, what was the reason?

@zachgersh

This comment has been minimized.

Contributor

zachgersh commented Jul 10, 2013

hey @kewljedi you actually need to direct documentation updates toward master (hence why @mattr- reverted your change).

Can you make another pull directed at master instead?

@mattr-

This comment has been minimized.

Member

mattr- commented Jul 10, 2013

Because I'm merging it into a different branch.

On Wed, Jul 10, 2013 at 12:52 PM, Donald Perry notifications@github.comwrote:

The merge was reverted and the pull request left closed, what was the
reason?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1294#issuecomment-20760263
.

mattr- added a commit that referenced this pull request Jul 10, 2013

Update the S3 deployment documentation
This is just #1294 on the appropriate branch.
@kewljedi

This comment has been minimized.

Contributor

kewljedi commented Jul 10, 2013

Thank you very much!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.