New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redcarpet 3.0.0 #1299

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@mattr-

This comment has been minimized.

Member

mattr- commented Jul 11, 2013

Sadly, I have to give a 👎 on this one. Redcarpet 3.0.0 removes
1.8.7 compatibility.

On Thu, Jul 11, 2013 at 9:20 AM, Parker Moore notifications@github.com wrote:

http://mattr.info/2013/07/09/redcarpet-3-0-0.html


You can merge this Pull Request by running

git pull https://github.com/mojombo/jekyll redcarpet-3.0.0

Or view, comment on, or merge it at:

#1299

Commit Summary

Redcarpet 3.0.0

File Changes

M jekyll.gemspec (2)

Patch Links:

https://github.com/mojombo/jekyll/pull/1299.patch
https://github.com/mojombo/jekyll/pull/1299.diff

@parkr

This comment has been minimized.

Member

parkr commented Jul 11, 2013

Ew. 2.0 it is then! I totally glossed over that in your post.

@parkr parkr closed this Jul 11, 2013

@parkr parkr deleted the redcarpet-3.0.0 branch Jul 11, 2013

@zealot128

This comment has been minimized.

zealot128 commented Sep 27, 2013

That's too bad, since Redcarpet 3 introduced Footnotes. Seems, I have to keep a local branch of jekyll myself then :(

@mathiasbynens

This comment has been minimized.

mathiasbynens commented Feb 26, 2014

So is there no way to use Redcarpet 3 with the current v1.4.3 of Jekyll (without forking it)?

For example, if it were possible to make redcarpet 3.1.1 pretend like it’s 2.3.0 as far as Jekyll is concerned, that would solve the problem (in a really dirty, hacky way, but still).

Update: Hah, the above seems to work.

gem install redcarpet; # installs the latest version, i.e. v3
gemdir="$(gem environment gemdir)";
rm -rf "${gemdir}/gems/redcarpet-2.3.0";
mv "${gemdir}"/gems/redcarpet-3* "${gemdir}/gems/redcarpet-2.3.0";

But I need a shower now.

@mattr-

This comment has been minimized.

Member

mattr- commented Feb 26, 2014

Jekyll 1.4.3 still supports Ruby 1.8.7, which is why it doesn't pull in
any of the Redcarpet 3.x releases. Redcarpet 3 dropped support for Ruby
1.8.7. While your above hack does work, it's just that, a hack. If it
keeps working for you, go for it, but caveat emptor.

@mathiasbynens

This comment has been minimized.

mathiasbynens commented Feb 26, 2014

@mattr- Sure, I understood that when reading the above comments.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.