Add support for liquid in post excerpts #1302

Merged
merged 2 commits into from Jul 14, 2013

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented Jul 13, 2013

  • Break out Excerpt into its own class, including Convertible
  • Hook excerpt rendering into post rendering
  • Fix post tests for excerpts so they render instead of just transform
  • Write tests specifically for Excerpt??

@mattr-

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 13, 2013

Member

@mattr- Please review. I'd love to push this out tomorrow!

Member

parkr commented Jul 13, 2013

@mattr- Please review. I'd love to push this out tomorrow!

+ #
+ # Returns the representative Hash.
+ def to_liquid
+ further_data = Hash[ATTRIBUTES_FOR_LIQUID.map { |attribute|

This comment has been minimized.

@mattr-

mattr- Jul 14, 2013

Member

I'm not completely up to speed on Ruby's constant lookup. How does this ATTRIBUTES_FOR_LIQUID constant get resolved when it's actually on the Post class?

@mattr-

mattr- Jul 14, 2013

Member

I'm not completely up to speed on Ruby's constant lookup. How does this ATTRIBUTES_FOR_LIQUID constant get resolved when it's actually on the Post class?

This comment has been minimized.

@parkr

parkr Jul 14, 2013

Member

Hm... no I don't think it does. Totally missed that!

@parkr

parkr Jul 14, 2013

Member

Hm... no I don't think it does. Totally missed that!

This comment has been minimized.

@parkr

parkr Jul 14, 2013

Member

Also don't throw yourself under the bus by saying you're not up to speed - I know that's not true ;) ❤️

@parkr

parkr Jul 14, 2013

Member

Also don't throw yourself under the bus by saying you're not up to speed - I know that's not true ;) ❤️

This comment has been minimized.

@parkr

parkr Jul 14, 2013

Member

Fixed it in d815c12 :)

@parkr

parkr Jul 14, 2013

Member

Fixed it in d815c12 :)

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Jul 14, 2013

Member

I love the extraction of the extract class here. That is fantastic.

We can add tests for Excerpt later, if needed, since it's just an implementation detail of a post.

I'm 👍 on this.

Member

mattr- commented Jul 14, 2013

I love the extraction of the extract class here. That is fantastic.

We can add tests for Excerpt later, if needed, since it's just an implementation detail of a post.

I'm 👍 on this.

mattr- added a commit that referenced this pull request Jul 14, 2013

Merge pull request #1302 from mojombo/excerpt
Add support for liquid in post excerpts

@mattr- mattr- merged commit 17c2296 into master Jul 14, 2013

1 check passed

default The Travis CI build passed
Details

mattr- added a commit that referenced this pull request Jul 14, 2013

@parkr parkr deleted the excerpt branch Jul 14, 2013

@@ -260,6 +252,8 @@ def render(layouts, site_payload)
"page" => self.to_liquid
}.deep_merge(site_payload)
+ self.extracted_excerpt.do_layout(payload, layouts)

This comment has been minimized.

@rwboyer

rwboyer Jul 15, 2013

Something feels strange right here...

haven't really dug in yet but guessing this is what is causing some serious strangeness with a lot of Jekyll sites since 1.1.0.

See issue #1307

@rwboyer

rwboyer Jul 15, 2013

Something feels strange right here...

haven't really dug in yet but guessing this is what is causing some serious strangeness with a lot of Jekyll sites since 1.1.0.

See issue #1307

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.