Skip to content

Add support for liquid in post excerpts#1302

Merged
mattr- merged 2 commits intomasterfrom
excerpt
Jul 14, 2013
Merged

Add support for liquid in post excerpts#1302
mattr- merged 2 commits intomasterfrom
excerpt

Conversation

@parkr
Copy link
Member

@parkr parkr commented Jul 13, 2013

  • Break out Excerpt into its own class, including Convertible
  • Hook excerpt rendering into post rendering
  • Fix post tests for excerpts so they render instead of just transform
  • Write tests specifically for Excerpt??

@mattr-

@parkr parkr mentioned this pull request Jul 13, 2013
Closed
@parkr
Copy link
Member Author

parkr commented Jul 13, 2013

@mattr- Please review. I'd love to push this out tomorrow!

mattr-
mattr- reviewed Jul 14, 2013
View reviewed changes
lib/jekyll/excerpt.rb
Copy link
Member

@mattr- mattr- Jul 14, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not completely up to speed on Ruby's constant lookup. How does this ATTRIBUTES_FOR_LIQUID constant get resolved when it's actually on the Post class?

Copy link
Member Author

@parkr parkr Jul 14, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... no I don't think it does. Totally missed that!

Copy link
Member Author

@parkr parkr Jul 14, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also don't throw yourself under the bus by saying you're not up to speed - I know that's not true ;) ❤️

Copy link
Member Author

@parkr parkr Jul 14, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it in d815c12 :)

@mattr-
Copy link
Member

mattr- commented Jul 14, 2013

I love the extraction of the extract class here. That is fantastic.

We can add tests for Excerpt later, if needed, since it's just an implementation detail of a post.

I'm 👍 on this.

mattr- added a commit that referenced this pull request Jul 14, 2013
@mattr-
Merge pull request #1302 from mojombo/excerpt
17c2296 
Add support for liquid in post excerpts
@mattr- mattr- merged commit 17c2296 into master Jul 14, 2013
mattr- added a commit that referenced this pull request Jul 14, 2013
@mattr-
Update history to reflect merge of #1302
21b52bb
@parkr parkr deleted the excerpt branch July 14, 2013 02:14
@rwboyer rwboyer mentioned this pull request Jul 15, 2013
Closed
rwboyer
rwboyer reviewed Jul 15, 2013
View reviewed changes
lib/jekyll/post.rb
Copy link

@rwboyer rwboyer Jul 15, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something feels strange right here...

haven't really dug in yet but guessing this is what is causing some serious strangeness with a lot of Jekyll sites since 1.1.0.

See issue #1307

@parkr parkr mentioned this pull request Aug 6, 2013
Merged
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

fix frozen-due-to-age

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@parkr @mattr- @rwboyer @jekyllbot