Add support for liquid in post excerpts #1302
Conversation
|
@mattr- Please review. I'd love to push this out tomorrow! |
| # | ||
| # Returns the representative Hash. | ||
| def to_liquid | ||
| further_data = Hash[ATTRIBUTES_FOR_LIQUID.map { |attribute| |
There was a problem hiding this comment.
I'm not completely up to speed on Ruby's constant lookup. How does this ATTRIBUTES_FOR_LIQUID constant get resolved when it's actually on the Post class?
There was a problem hiding this comment.
Hm... no I don't think it does. Totally missed that!
There was a problem hiding this comment.
Also don't throw yourself under the bus by saying you're not up to speed - I know that's not true ;) ❤️
|
I love the extraction of the extract class here. That is fantastic. We can add tests for I'm 👍 on this. |
Add support for liquid in post excerpts
| @@ -260,6 +252,8 @@ def render(layouts, site_payload) | |||
| "page" => self.to_liquid | |||
| }.deep_merge(site_payload) | |||
|
|
|||
| self.extracted_excerpt.do_layout(payload, layouts) | |||
There was a problem hiding this comment.
Something feels strange right here...
haven't really dug in yet but guessing this is what is causing some serious strangeness with a lot of Jekyll sites since 1.1.0.
See issue #1307
ConvertibleExcerpt??@mattr-