No layouts for excerpt#1339
Conversation
…y are still converted with liquid and the proper converter
There was a problem hiding this comment.
@mattr- The key to get it to convert was to make sure Post#excerpt was not called before the excerpt was converted. This seems to fix all the things!
|
@benbalter this will likely be my last PR for v1.1.1 so we can get it shipped today or (at the very latest) tomorrow. |
There was a problem hiding this comment.
should this be {{ post.excerpt }} for consistency?
There was a problem hiding this comment.
No, the variable used in the layout is page, not post
There was a problem hiding this comment.
😕 Why is it page and not post? Seems weird to me.
There was a problem hiding this comment.
It's to be consistent so you can use the same layout for pages and for posts if you want.
Always the same variable for the #to_liquid hash
|
Just the one fixup and I think this should be good. |
|
@mattr- Please merge when ready :) |
5 participants
Aims to fix #1321.