Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sites.md, add ruby's official site #1358

Merged
merged 1 commit into from Jul 29, 2013

Conversation

Projects
None yet
6 participants
@take
Copy link
Contributor

take commented Jul 28, 2013

No description provided.

@kelvinst

This comment has been minimized.

Copy link

kelvinst commented Jul 28, 2013

@parkr, I think this is a great idea, since the intent of the page changes is show some sites written with Jekyll, and I think that ruby's official site is a great example 😃

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Jul 28, 2013

Great idea! I might put it last in the list (it's more complicated and thus more "advanced") but I'm 👍 for including it. @mattr-?

@take

This comment has been minimized.

Copy link
Contributor Author

take commented Jul 28, 2013

Great idea! I might put it last in the list (it's more complicated and thus more "advanced"

true! 👍

@jpiasetz

This comment has been minimized.

Copy link
Contributor

jpiasetz commented Jul 29, 2013

Should this sentence be changed as well?

Below are some Jekyll-powered blogs which were hand-picked for learning purposes.

Maybe something like:

Below are some notable Jekyll-powered blogs which show the range of customization options.

Might be good to move the github one down as well?

@take

This comment has been minimized.

Copy link
Contributor Author

take commented Jul 29, 2013

Or maybe

Below are some Jekyll-powered blogs/sites which were hand-picked for learning purposes.

..?

@take

This comment has been minimized.

Copy link
Contributor Author

take commented Jul 29, 2013

Might be good to move the github one down as well?

👍

@mattr-

This comment has been minimized.

Copy link
Member

mattr- commented Jul 29, 2013

There's no need to unnecessarily wordsmith everything. Just move the info for the ruby-lang.org site down to the bottom since it's a more complicated site and then let's get this thing merged.

@take

This comment has been minimized.

Copy link
Contributor Author

take commented Jul 29, 2013

@mattr- done 😃

@mattr-

This comment has been minimized.

Copy link
Member

mattr- commented Jul 29, 2013

Awesome! Thanks!

@jpiasetz There's definitely some room for some different wording on this page. I'd love to see your thoughts in a separate pull request. 😃

mattr- added a commit that referenced this pull request Jul 29, 2013

Merge pull request #1358 from tkhr/patch-1
Update sites.md, add ruby's official site

@mattr- mattr- merged commit 3820854 into jekyll:gh-pages Jul 29, 2013

mattr- added a commit that referenced this pull request Jul 29, 2013

@take take deleted the take:patch-1 branch Jul 29, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.