Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use binary mode when writing file. #1364

Merged
merged 1 commit into from Aug 7, 2013

Conversation

Projects
None yet
6 participants
@koron
Copy link
Contributor

commented Jul 30, 2013

When using jekyll on Windows, generated files have different EOL from UNIX system.
This small patch makes it same EOL.

@parkr

This comment has been minimized.

Copy link
Member

commented Jul 30, 2013

Good idea. @mattr-?

@kelvinst

This comment has been minimized.

Copy link

commented Jul 30, 2013

Very good...

@jpiasetz

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2013

@parkr didn't you say in another pull Jekyll doesn't support windows 😆?

@parkr

This comment has been minimized.

Copy link
Member

commented Aug 2, 2013

@jpiasetz Yeah, we don't officially support Windows. This patch doesn't change anything for UNIX (apparently) but helps windows peeps so I'm down.

@koron

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2013

we don't officially support Windows

BTW, what are problems to officialy support Windows? I may help it.

@mattr-

This comment has been minimized.

Copy link
Member

commented Aug 2, 2013

The problem is that we don't have anybody that's focused on making sure it
works with windows. 😃

On Thu, Aug 1, 2013 at 8:02 PM, MURAOKA Taro notifications@github.comwrote:

we don't officially support Windows

BTW, what are problems to officialy support Windows? I may help it.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1364#issuecomment-21980633
.

@jpiasetz

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2013

I have access to a bunch of windows machines that I could test releases on.

@mattr-

This comment has been minimized.

Copy link
Member

commented Aug 2, 2013

That would be totally awesome.

@parkr

This comment has been minimized.

Copy link
Member

commented Aug 6, 2013

@mattr- Think this is OK to merge? Travis (linux) seems to like it OK.

@mattr-

This comment has been minimized.

Copy link
Member

commented Aug 7, 2013

yeah, i think this is fine. :shipit:

parkr added a commit that referenced this pull request Aug 7, 2013

Merge pull request #1364 from koron/write-in-binary-mode
use binary mode when writing file.

@parkr parkr merged commit 826293e into jekyll:master Aug 7, 2013

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Aug 7, 2013

@koron

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2013

🙇

@koron koron deleted the koron:write-in-binary-mode branch Dec 22, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.