New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement URL conflict checking in `jekyll-doctor`. #1389

Merged
merged 4 commits into from Aug 18, 2013

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented Aug 6, 2013

Satisfies #1077.
Alternative to #1361.

@parkr

This comment has been minimized.

Member

parkr commented Aug 6, 2013

Sample output:

~/code/jekyll/tsite$ ../bin/jekyll doctor
Configuration file: /Users/parker/code/jekyll/tsite/_config.yml
          Conflict: The URL '/Users/parker/code/jekyll/tsite/_site/index.html' is the destination for the following pages: index.html, something/index.html
@kelvinst

This comment has been minimized.

kelvinst commented Aug 8, 2013

Nice feature (=
Revised and good to merge

@parkr

This comment has been minimized.

Member

parkr commented Aug 8, 2013

urls = {}
urls = collect_urls(urls, site.pages, site.dest)
urls = collect_urls(urls, site.posts, site.dest)
#urls = collect_urls(urls, site.static_files)

This comment has been minimized.

@mattr-

mattr- Aug 8, 2013

Member

💣 the comment, please 😃

@mattr-

This comment has been minimized.

Member

mattr- commented Aug 8, 2013

Just one small nitpick and then I think it's good to go.

@parkr

This comment has been minimized.

Member

parkr commented Aug 8, 2013

Also aborting if unhealthy returns true

[
deprecated_relative_permalinks(site),
conflicting_urls(site)
].any?

This comment has been minimized.

@parkr

parkr Aug 17, 2013

Member

@mattr- I'm worried this will only evaluate until one of them returns true.

@mattr-

This comment has been minimized.

Member

mattr- commented Aug 18, 2013

👍 :shipit:

mattr- added a commit that referenced this pull request Aug 18, 2013

Merge pull request #1389 from mojombo/doctor-conflicting-permalinks
Implement URL conflict checking in `jekyll-doctor`.

@mattr- mattr- merged commit 820f526 into master Aug 18, 2013

1 check passed

default The Travis CI build passed
Details

mattr- added a commit that referenced this pull request Aug 18, 2013

@parkr parkr deleted the doctor-conflicting-permalinks branch Aug 19, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.