New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch and fix (somehow) common configuration errors #1390

Merged
merged 4 commits into from Aug 7, 2013

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Aug 6, 2013

If a user makes a common mistake in his or her config file, we should be nice
enough to catch it and print an error message. An example of this is when
paginate is set to true. As @benbalter points out, a user will see

error: undefined method to_i' for true:TrueClass

This isn't helpful very helpful so if as we find them over time, it might be
nice to catch them and be more helpful instead of frustrating.

Related to #1105.

parkr added some commits Aug 6, 2013

Print warning when `paginate` is set to `true`.
Related to #1105.

Sample output:
~/code/jekyll/tsite$ ../bin/jekyll build --trace
Configuration file: /Users/parker/code/jekyll/tsite/_config.yml
    Config Warning: The `paginate` key must be a positive integer or nil. It's currently set to 'true'.
            Source: /Users/parker/code/jekyll/tsite
       Destination: /Users/parker/code/jekyll/tsite/_site
      Generating... done.

@parkr parkr referenced this pull request Aug 6, 2013

Closed

Better Converter Feedback #1105

3 of 5 tasks complete
@mattr-

This comment has been minimized.

Member

mattr- commented Aug 7, 2013

👍 from me. :shipit:

parkr added a commit that referenced this pull request Aug 7, 2013

Merge pull request #1390 from mojombo/better-errors
Catch and fix (somehow) common configuration errors

@parkr parkr merged commit cb52535 into master Aug 7, 2013

1 check passed

default The Travis CI build passed
Details

@parkr parkr deleted the better-errors branch Aug 7, 2013

parkr added a commit that referenced this pull request Aug 7, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.