New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add site.repository for the URL on Github. Close #1456 #1463

Merged
merged 1 commit into from Aug 30, 2013

Conversation

Projects
None yet
3 participants
@doktorbro
Member

doktorbro commented Aug 28, 2013

This is a duplicate for #1456 that was pushed from my master branch instead of new one. This PR is proper. Sorry for that.

@parkr

This comment has been minimized.

Member

parkr commented Aug 28, 2013

Thanks! LGTM. We have to remember to update the rake task for generating the History file though.

@@ -51,7 +51,7 @@ end
def linkify_prs(markdown)
markdown.gsub(/#(\d+)/) do |word|
"[#{word}](https://github.com/mojombo/jekyll/issues/#{word.delete("#")})"
"[#{word}]({{ site.repository }}/issues/#{word.delete("#")})"

This comment has been minimized.

@doktorbro

doktorbro Aug 28, 2013

Member

@parkr Do you mean this task? I hope it’s correct, I don’t really know how Ruby handles strings.

This comment has been minimized.

@parkr

parkr Aug 28, 2013

Member

Yes, that should work. Sorry, didn't see it initially.

@parkr

This comment has been minimized.

Member

parkr commented Aug 28, 2013

parkr added a commit that referenced this pull request Aug 30, 2013

Merge pull request #1463 from penibelst/add-site-repository
Add site.repository for the URL on Github. Close #1456

@parkr parkr merged commit 6475cce into jekyll:master Aug 30, 2013

1 check passed

default The Travis CI build passed
Details

parkr added a commit that referenced this pull request Aug 30, 2013

@doktorbro doktorbro deleted the doktorbro:add-site-repository branch Aug 31, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.