New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs/templates.md private gist example #1477

Merged
merged 1 commit into from Aug 30, 2013

Conversation

Projects
None yet
4 participants
@mroderick
Contributor

mroderick commented Aug 30, 2013

In latest Jekyll, the gist tag should use the GitHub username of the
owner of the private gist being embedded.

Fix docs/templates.md private gist example
In latest Jekyll, the gist tag should use the GitHub username of the
owner of the private gist being embedded.
@kelvinst

This comment has been minimized.

kelvinst commented Aug 30, 2013

Nice!

@parkr

This comment has been minimized.

Member

parkr commented Aug 30, 2013

Is this required by the API?

@mroderick

This comment has been minimized.

Contributor

mroderick commented Aug 30, 2013

I believe so, the API changed earlier this year. The example does not work without it, but does work with it.

@parkr

This comment has been minimized.

Member

parkr commented Aug 30, 2013

Cool, then it LGTM. @mattr-?

parkr added a commit that referenced this pull request Aug 30, 2013

Merge pull request #1477 from mroderick/fix-templates.md-private-gist…
…-example

Fix docs/templates.md private gist example

@parkr parkr merged commit e26d992 into jekyll:gh-pages Aug 30, 2013

parkr added a commit that referenced this pull request Aug 30, 2013

Fix docs/templates.md private gist example.
Duplicate of #1477 because we develop on the master branch.

parkr added a commit that referenced this pull request Aug 30, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.