New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Jekyll version to templates: `jekyll.version` #1481

Merged
merged 5 commits into from Sep 5, 2013

Conversation

Projects
None yet
6 participants
@parkr
Member

parkr commented Aug 30, 2013

@pathawks describes in #1428 his intentions for this. @mattr- suggested that it should be jekyll.version instead of site.version so I update the site_payload to reflect this (as I agree).

pathawks and others added some commits Aug 17, 2013

Expose Jekyll version to templates
Make available `site.version` to liquid
Merge branch 'patch-1' of git://github.com/pathawks/jekyll into patha…
…wks-patch-1

* 'patch-1' of git://github.com/pathawks/jekyll:
  Use proper Ruby syntax for constant
  Expose Jekyll version to templates
@parkr

This comment has been minimized.

Member

parkr commented Aug 30, 2013

@mattr-

Maybe @benbalter has some ideas as to what else might be useful in the jekyll namespace.

@pathawks

This comment has been minimized.

Member

pathawks commented Aug 31, 2013

👍 Thank you much

@parkr

This comment has been minimized.

Member

parkr commented Aug 31, 2013

@benbalter I couldn't see any conflicts during a GitHub Code search but then again I couldn't actually search directly for jekyll:.

@benbalter

This comment has been minimized.

Contributor

benbalter commented Sep 2, 2013

I couldn't see any conflicts during a GitHub Code search

How would their be a conflict? User YML is namespaced into site and page, no?

@maul-esel

This comment has been minimized.

Contributor

maul-esel commented Sep 2, 2013

{% assign jekyll = 'hello' %}
<h1>{{ jekyll }} world</h1>
Written with Jekyll {{ jekyll.version }}.

😸

@benbalter

This comment has been minimized.

Contributor

benbalter commented Sep 2, 2013

@maul-esel

This comment has been minimized.

Contributor

maul-esel commented Sep 2, 2013

Nor does a search for capture jekyll yield any relevant results. So I guess the incompatibility is of tolerable extent.

@parkr

This comment has been minimized.

Member

parkr commented Sep 4, 2013

YAY! :shipit: @mattr-?

@maul-esel

This comment has been minimized.

Contributor

maul-esel commented Sep 5, 2013

As a note, the concern I presented above is most likely invalid anyway, as {% assign jekyll %} would override the variable. Thus it is not strictly backwards-incompatible as old sites run just like before, without any change.

It'd be just a small change for those who want to use the new feature but have jekyll variables of their own (few enough, as @benbalter pointed out).

mattr- added a commit that referenced this pull request Sep 5, 2013

Merge pull request #1481 from mojombo/pathawks-patch-1
Expose Jekyll version to templates: `jekyll.version`

@mattr- mattr- merged commit 3212aac into master Sep 5, 2013

1 check passed

default The Travis CI build passed
Details
@mattr-

This comment has been minimized.

Member

mattr- commented Sep 5, 2013

🚢ed!

mattr- added a commit that referenced this pull request Sep 5, 2013

@parkr parkr deleted the pathawks-patch-1 branch Sep 5, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.