New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kramdown as a gem dependency #1498

Merged
merged 2 commits into from Sep 5, 2013

Conversation

Projects
None yet
4 participants
@troyswanson
Member

troyswanson commented Sep 3, 2013

Per @parkr's comment in #1473, removing kramdown as a dependency in the gemspec.

@mattr-

This comment has been minimized.

Member

mattr- commented Sep 3, 2013

It still needs to be a development dependency.

@troyswanson

This comment has been minimized.

Member

troyswanson commented Sep 3, 2013

K, added back.

@parkr

This comment has been minimized.

Member

parkr commented Sep 4, 2013

I'm 👍 for this. Does the KramdownConverter have a nice error message?

@troyswanson

This comment has been minimized.

Member

troyswanson commented Sep 4, 2013

@parkr - Where would I see that?

@parkr

This comment has been minimized.

Member

parkr commented Sep 4, 2013

In lib/jekyll/converters/markdown/kramdown.rb I think?

@troyswanson

This comment has been minimized.

Member

troyswanson commented Sep 4, 2013

It certainly looks like it.

From lib/jekyll/converters/markdown/kramdown_parser.rb:

def initialize(config)
  require 'kramdown'
  @config = config
rescue LoadError
  STDERR.puts 'You are missing a library required for Markdown. Please run:'
  STDERR.puts '  $ [sudo] gem install kramdown'
  raise FatalException.new("Missing dependency: kramdown")
end

Is this what you mean? (Sorry if not. I don't quite understand.)

@parkr

This comment has been minimized.

Member

parkr commented Sep 4, 2013

Yep, that's what I mean! LGTM.

@mattr-?

mattr- added a commit that referenced this pull request Sep 5, 2013

@mattr- mattr- merged commit 8a20c2b into jekyll:master Sep 5, 2013

1 check passed

default The Travis CI build passed
Details

mattr- added a commit that referenced this pull request Sep 5, 2013

@troyswanson

This comment has been minimized.

Member

troyswanson commented Sep 5, 2013

Thanks guys!

@troyswanson troyswanson deleted the troyswanson:remove-kramdown-as-dependency branch Sep 5, 2013

@troyswanson

This comment has been minimized.

Member

troyswanson commented Sep 6, 2013

PS: README.md should be updated to reflect the new dependencies. (Sorry I didn't notice this before I put in the PR)

parkr added a commit that referenced this pull request Sep 7, 2013

@kkabetani kkabetani referenced this pull request Sep 21, 2013

Merged

add kramdown #121

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.