New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for new Data Files feature #1503

Merged
merged 3 commits into from Oct 3, 2013

Conversation

Projects
None yet
6 participants
@swanson
Contributor

swanson commented Sep 4, 2013

Add documentation for the new Data Files feature introduced in #1003.

The original PR includes additions to /structure/ so they have been omitted here.

@parkr

View changes

site/docs/data.md Outdated
This data can be accessed via `site.data.members` (notice that the filename
determines the variable name).
You can now do render the list of members in a template:

This comment has been minimized.

@parkr

parkr Sep 4, 2013

Member

Is the do meant to be there?

@parkr

View changes

site/docs/data.md Outdated
{% raw %}{{ member.name }}{% endraw %}
</a>
</li>
{% raw %}{% end %}{% endraw %}

This comment has been minimized.

@parkr

parkr Sep 4, 2013

Member

This block you can be encompassed entirely by {% raw %} tags. No need to specify raw tags for each liquid statement within, as they all must be raw.

@parkr

View changes

site/docs/data.md Outdated
layout: docs
title: Data Files
prev_section: variables
next_section: migrations

This comment has been minimized.

@parkr

parkr Sep 4, 2013

Member

Migrations will have to be updated, no?

This comment has been minimized.

@swanson

swanson Sep 5, 2013

Contributor

Yes, good catch. Fixed.

@parkr

This comment has been minimized.

Member

parkr commented Sep 4, 2013

This looks great!! Thanks for putting this together.

@liufengyun

This comment has been minimized.

Contributor

liufengyun commented Sep 5, 2013

Thanks @swanson .

It seems the test features/site_data.feature:35 is a little unstable. The travis CI failed.

https://travis-ci.org/mojombo/jekyll/builds/10989828

@swanson

This comment has been minimized.

Contributor

swanson commented Sep 5, 2013

Corrections made.

@parkr

This comment has been minimized.

Member

parkr commented Sep 5, 2013

LGTM!

@mattr-

This comment has been minimized.

Member

mattr- commented Sep 10, 2013

LGTM to me too!

@swanson

This comment has been minimized.

Contributor

swanson commented Oct 1, 2013

@mattr- @parkr can we merge this now that #1003 is in?

@mattr-

This comment has been minimized.

Member

mattr- commented Oct 1, 2013

We can. Could you rebase it so it's current with latest master and I can just hit the big green button? Thanks!

@swanson

This comment has been minimized.

Contributor

swanson commented Oct 1, 2013

@mattr- should be good to go once Travis runs. Might give it a quick once over, somewhere upstream the menu items were moved to an includes, so this wasn't strictly a rebase (as there was a merge conflict that needed to be addressed).

@parkr

This comment has been minimized.

Member

parkr commented Oct 1, 2013

@mattr- What happened to the tests?

@maul-esel

This comment has been minimized.

Contributor

maul-esel commented Oct 1, 2013

@parkr: I think it's the MaRuKu release 0.7.0, because exactly the same failures already occured before in #1558.

mattr- added a commit that referenced this pull request Oct 3, 2013

@mattr- mattr- merged commit b723a58 into jekyll:master Oct 3, 2013

1 check failed

default The Travis CI build could not complete due to an error
Details

mattr- added a commit that referenced this pull request Oct 3, 2013

@swanson swanson deleted the swanson:add-docs-for-data-feature branch Oct 3, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.